ide-disk: Fix LBA8 DMA
Quoted 10 lines · Chuck Ebbert
drivers/ide/ide-disk.c 2005-05-20 09:36:31.933319224 -0700 line 134
Quoted 5 lines · Chris Wright
drivers/ide/ide-disk.c 2005-05-20 09:36:31.933319224 -0700 renamed from drivers/ide/ide-disk.c 2005-05-16 10:50:31.000000000 -0700 +0
-0@@ -133,6 +133,8 @@ if (hwif->no_lba48_dma && lba48 && dma) { if (block + rq->nr_sectors > 1ULL << 28)^
Quoted 2 lines
Maybe I'm an idiot, but shouldn't that be ">="? Either that or it should be
comparing to (1ULL < 28 - 1)?
Oops, I forgot this was in my outbox and sent it before review. This code
is fine... (block + rq->nr_sectors) is one past the actual end of the read.
Quoted 7 lines
drivers/ide/ide-disk.c 2005-05-20 09:36:31.933319224 -0700 line 137
Quoted 3 lines
drivers/ide/ide-disk.c 2005-05-20 09:36:31.933319224 -0700 renamed from drivers/ide/ide-disk.c 2005-05-16 10:50:31.000000000 -0700 +2
-0dma = 0; + else + lba48 = 0;^^^^^^^^^^^^^^^^^^^^^^^Spaces instead of tabs?
But the patch really does seem to be tabdamaged...
--
Chuck
Quoted 9 lines · * Chuck Ebbert ([email protected]) wrote:
Quoted 6 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ else + lba48 = 0;^^^^^^^^^^^^^^^^^^^^^^^Spaces instead of tabs?
But the patch really does seem to be tabdamaged...
Yes, I'll refresh, thanks.
-chris