Skip to contentSkip to conversation

show swsuspend only on .config where it can compile

PATCH Applied Olaf Hering 3 participants 4 messages May 26, 2005

Subsystems (2)
Suspend to RAM Hibernation
lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 show swsuspend only on .config where it can compile

show swsuspend only on .config where it can compile. I got this on PPC32 && SMP

kernel/power/smp.c:24: error: storage size of `ctxt' isn't known

Signed-off-by Olaf Hering <[email protected]>
kernel/power/Kconfig +1 -1
Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
===================================================================
@@ -28,7 +28,7 @@ config PM_DEBUG
 
 config SOFTWARE_SUSPEND
 	bool "Software Suspend (EXPERIMENTAL)"
-	depends on EXPERIMENTAL && PM && SWAP
+	depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)
 	---help---
 	  Enable the possibility of suspending the machine.
 	  It doesn't need APM.
Applied
#1 lore raw
Quoted 6 lines · Olaf Hering

show swsuspend only on .config where it can compile. I got this on PPC32 && SMP

kernel/power/smp.c:24: error: storage size of `ctxt' isn't known

Signed-off-by Olaf Hering <[email protected]>

Thanks, applied. Also swsusp is pretty stable now, so I'll mark it as stable.
Pavel

#2 lore raw
In reply to Olaf Hering
Quoted 12 lines · Olaf Hering

show swsuspend only on .config where it can compile. I got this on PPC32 && SMP

kernel/power/smp.c:24: error: storage size of `ctxt' isn't known

Signed-off-by Olaf Hering <[email protected]>

Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
===================================================================

kernel/power/Kconfig config PM_DEBUG · line 31

Quoted 5 lines
kernel/power/Kconfig +1 -1
@@ -28,7 +28,7 @@ config PM_DEBUG
 
 config SOFTWARE_SUSPEND
 	bool "Software Suspend (EXPERIMENTAL)"
-	depends on EXPERIMENTAL && PM && SWAP
+	depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)

Shouldn't be ...&& ( (X86 && SMP) || (FVR || PPC32 || X86) && !SMP ) ?

and maybe

EXPERIMENTAL && PM && SWAP && ( X86 || ((FVR || PPC32) && !SMP) )

is clearer?

Signature · 2 lines
Romano Giannetti             -  Univ. Pontificia Comillas (Madrid, Spain)
Electronic Engineer - phone +34 915 422 800 ext 2416  fax +34 915 596 569
#3 lore raw

Hi!

Quoted 10 lines
Quoted 10 lines

kernel/power/smp.c:24: error: storage size of `ctxt' isn't known

Signed-off-by Olaf Hering <[email protected]>

Index: linux-2.6.12-rc5-olh/kernel/power/Kconfig
===================================================================

kernel/power/Kconfig +0 -0
@@ -28,7 +28,7 @@ config PM_DEBUG
Quoted 7 lines

kernel/power/Kconfig config PM_DEBUG · line 31

Quoted 4 lines
kernel/power/Kconfig +1 -1
 config SOFTWARE_SUSPEND
 	bool "Software Suspend (EXPERIMENTAL)"
-	depends on EXPERIMENTAL && PM && SWAP
+	depends on EXPERIMENTAL && PM && SWAP && (X86 && SMP) || ((FVR || PPC32 || X86) && !SMP)

Shouldn't be ...&& ( (X86 && SMP) || (FVR || PPC32 || X86) && !SMP )

Quoted 1 line

?

Missing parenthesis added, thanks.
Pavel