Skip to contentSkip to conversation

s390: schedule_timeout cleanup in ctctty

PATCH In review Frank Pavlic 2 participants 3 messages May 27, 2005 – May 29, 2005

Subsystems (3)
Network drivers s390 s390 network drivers
lore
Share & tools
lore

Frank Pavlic

author
#0 lore raw

PATCH 4/10 s390: schedule_timeout cleanup in ctctty

[patch 4/10] s390: schedule_timeout cleanup in ctctty.

From: Domen Puncer <[email protected]>

Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>
Signed-off-by Domen Puncer <[email protected]>
Signed-off-by Frank Pavlic <[email protected]>
Acked-by Martin Schwidefsky <[email protected]>

diffstat:

 drivers/s390/net/ctctty.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
drivers/s390/net/ctctty.c +2 -3
diff -urpN linux-2.6/drivers/s390/net/ctctty.c linux-2.6-patched/drivers/s390/net/ctctty.c
@@ -1,5 +1,5 @@
 /*
- * $Id: ctctty.c,v 1.26 2004/08/04 11:06:55 mschwide Exp $
+ * $Id: ctctty.c,v 1.29 2005/04/05 08:50:44 mschwide Exp $
  *
  * CTC / ESCON network driver, tty interface.
  *

@@ -1056,8 +1056,7 @@ ctc_tty_close(struct tty_struct *tty, st
 	info->tty = 0;
 	tty->closing = 0;
 	if (info->blocked_open) {
-		set_current_state(TASK_INTERRUPTIBLE);
-		schedule_timeout(HZ/2);
+		msleep_interruptible(500);
 		wake_up_interruptible(&info->open_wait);
 	}
 	info->flags &= ~(CTC_ASYNC_NORMAL_ACTIVE | CTC_ASYNC_CLOSING);
#1 lore raw
Quoted 9 lines · Frank Pavlic

[patch 4/10] s390: schedule_timeout cleanup in ctctty.

From: Domen Puncer <[email protected]>

Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>

Actually it's from:
Nishanth Aravamudan <[email protected]>

Since then, I updated scripts to add the "From: " in the body, so this shouldn't be an issue in the future.

Quoted 5 lines
Signed-off-by Maximilian Attems <[email protected]>
Signed-off-by Domen Puncer <[email protected]>
Signed-off-by Frank Pavlic <[email protected]>
Acked-by Martin Schwidefsky <[email protected]>

Domen

author
#2 lore raw

Domen Puncer <[email protected]> wrote on 28.05.2005 11:53:18:

Quoted 17 lines · Frank Pavlic
Quoted 9 lines

[patch 4/10] s390: schedule_timeout cleanup in ctctty.

From: Domen Puncer <[email protected]>

Use msleep_interruptible() instead of schedule_timeout() to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>

Actually it's from:
Nishanth Aravamudan <[email protected]>

Since then, I updated scripts to add the "From: " in the body, so this shouldn't be an issue in the future.

Quoted 8 lines
Quoted 5 lines
Signed-off-by Maximilian Attems <[email protected]>
Signed-off-by Domen Puncer <[email protected]>
Signed-off-by Frank Pavlic <[email protected]>
Acked-by Martin Schwidefsky <[email protected]>

Domen

thank you for the correction ....

Frank