Skip to contentSkip to conversation

drivers/ide/: possible cleanups

PATCH In review Adrian Bunk 2 participants 3 messages May 30, 2005 libata

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 drivers/ide/: possible cleanups

This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready

Signed-off-by Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 30 Apr 200
- 17 Apr 2005

 drivers/ide/ide-iops.c     |    6 ------
 drivers/ide/ide-taskfile.c |    2 --
 drivers/ide/pci/cy82c693.c |    2 +-
 3 files changed, 1 insertion(+), 9 deletions(-)
drivers/ide/ide-taskfile.c renamed from drivers/ide/ide-taskfile.c.old +0 -2
@@ -161,8 +161,6 @@
 	return ide_stopped;
 }
 
-EXPORT_SYMBOL(do_rw_taskfile);
-
 /*
  * set_multmode_intr() is invoked on completion of a WIN_SETMULT cmd.
  */
drivers/ide/pci/cy82c693.c renamed from drivers/ide/pci/cy82c693.c.old +1 -1
@@ -469,7 +469,7 @@
 
 static __initdata ide_hwif_t *primary;
 
-void __init init_iops_cy82c693(ide_hwif_t *hwif)
+static void __init init_iops_cy82c693(ide_hwif_t *hwif)
 {
 	if (PCI_FUNC(hwif->pci_dev->devfn) == 1)
 		primary = hwif;
drivers/ide/ide-iops.c renamed from drivers/ide/ide-iops.c.old +0 -6
@@ -104,8 +104,6 @@
 	hwif->INSL	= ide_insl;
 }
 
-EXPORT_SYMBOL(default_hwif_iops);
-
 /*
  *	MMIO operations, typically used for SATA controllers
  */

@@ -329,8 +327,6 @@
 	hwif->atapi_output_bytes	= atapi_output_bytes;
 }
 
-EXPORT_SYMBOL(default_hwif_transport);
-
 /*
  * Beginning of Taskfile OPCODE Library and feature sets.
  */

@@ -525,8 +525,6 @@
 	return 0;
 }
 
-EXPORT_SYMBOL(wait_for_ready);
-
 /*
  * This routine busy-waits for the drive status to be not "busy".
  * It then checks the status for all of the "good" bits and none
#1 lore raw
Quoted 7 lines · Adrian Bunk

This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready

Are we sure we want to do that ? That would mean never having IDE host controller drivers as modules...

I was thinking about toying with that again for pmac one of these days ...

It may be worth, however, to rename those exported symbols to ide_*

Ben.

author
#2 lore raw
Quoted 9 lines · Benjamin Herrenschmidt
Quoted 7 lines · Adrian Bunk

This patch contains the following possible cleanups:
- pci/cy82c693.c: make a needlessly global function static
- remove the following unneeded EXPORT_SYMBOL's:
- ide-taskfile.c: do_rw_taskfile
- ide-iops.c: default_hwif_iops
- ide-iops.c: default_hwif_transport
- ide-iops.c: wait_for_ready

Quoted 7 lines

Are we sure we want to do that ? That would mean never having IDE host controller drivers as modules...

I was thinking about toying with that again for pmac one of these days ...

It may be worth, however, to rename those exported symbols to ide_*

My patch only removes the EXPORT_SYMBOL's.

It's always trivial to re-add them when you need them.

Quoted 1 line

Ben.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed