Kconfig: rename "---help---" to "help" in Kconfig files (first part) (fwd)
PATCH 1/1 Kconfig: rename "---help---" to "help" in Kconfig files (first part) (fwd)
This patch is the majority of a patch by Jesper Juhl.
This patch renames all instances of "---help---" to simply "help" in all of the Kconfig files.
The main reason for this patch (quoting Jesper) is:
Consistency. out of ~4000 help entries in 134 Kconfig files, 747 of those entries use "---help---" as the keyword, the rest use just "help". So the users of "---help---" are clearly a minority and by renaming them we make things consistent. - I hate inconsistency. :-)
Different ways for expressing the same thing is good for writers but bad for readers.
E.g. where to place opening braces in C is a religious issue. For the Linux kernel, CodingStyle sets the rules. And although I'd prefer to set them different, I have to admit that the consistency indide the kernel makes reading easier.
My change to the patch was to drop all parts that don't apply to both 2.6.12-rc5 and 2.6.12-rc5-mm1 (for making inclusion in Linus' tree easier).
My plan for this issue is:
- get this patch accepted
- rename all remaining "---help---" in both -mm and Linus' tree
- remove the "---help---" from the Kconfig language
---
This patch is attached gzip'ed because it's > 200 kB.
arch/alpha/Kconfig | 12 +- arch/arm/Kconfig | 10 +- arch/arm/mach-clps711x/Kconfig | 2 arch/arm26/Kconfig | 2 arch/cris/arch-v10/drivers/Kconfig | 4 arch/h8300/Kconfig | 6 - arch/i386/Kconfig | 26 +++--- arch/i386/kernel/cpu/cpufreq/Kconfig | 2 arch/ia64/Kconfig | 2 arch/m32r/Kconfig | 4 arch/m68k/Kconfig | 18 ++-- arch/m68knommu/Kconfig | 8 - arch/mips/Kconfig | 12 +- arch/parisc/Kconfig | 4 arch/ppc/Kconfig | 26 +++--- arch/ppc64/Kconfig | 6 - arch/s390/Kconfig | 4 arch/sh/Kconfig | 8 - arch/sh/cchips/Kconfig | 4 arch/sparc/Kconfig | 14 +-- arch/sparc64/Kconfig | 18 ++-- arch/um/Kconfig | 2 arch/x86_64/Kconfig | 6 - drivers/acpi/Kconfig | 12 +- drivers/atm/Kconfig | 16 +-- drivers/base/Kconfig | 2 drivers/block/Kconfig | 22 ++--- drivers/block/paride/Kconfig | 8 - drivers/cdrom/Kconfig | 20 ++-- drivers/char/Kconfig | 50 ++++++------ drivers/char/agp/Kconfig | 6 - drivers/char/ftape/Kconfig | 18 ++-- drivers/char/tpm/Kconfig | 6 - drivers/char/watchdog/Kconfig | 32 +++---- drivers/eisa/Kconfig | 8 - drivers/fc4/Kconfig | 4 drivers/i2c/Kconfig | 2 drivers/ide/Kconfig | 36 ++++---- drivers/infiniband/Kconfig | 2 drivers/infiniband/hw/mthca/Kconfig | 4 drivers/infiniband/ulp/ipoib/Kconfig | 6 - drivers/input/Kconfig | 12 +- drivers/input/gameport/Kconfig | 2 drivers/input/joystick/Kconfig | 6 - drivers/input/mouse/Kconfig | 4 drivers/input/serio/Kconfig | 12 +- drivers/isdn/Kconfig | 4 drivers/isdn/hisax/Kconfig | 2 drivers/macintosh/Kconfig | 2 drivers/md/Kconfig | 28 +++--- drivers/media/Kconfig | 2 drivers/media/dvb/Kconfig | 2 drivers/media/radio/Kconfig | 30 +++---- drivers/media/video/Kconfig | 20 ++-- drivers/message/i2o/Kconfig | 2 drivers/misc/Kconfig | 2 drivers/mtd/Kconfig | 16 +-- drivers/mtd/chips/Kconfig | 2 drivers/mtd/devices/Kconfig | 10 +- drivers/mtd/nand/Kconfig | 2 drivers/net/Kconfig | 110 +++++++++++++-------------- drivers/net/appletalk/Kconfig | 2 drivers/net/arcnet/Kconfig | 8 - drivers/net/hamradio/Kconfig | 12 +- drivers/net/irda/Kconfig | 8 - drivers/net/pcmcia/Kconfig | 4 drivers/net/tokenring/Kconfig | 12 +- drivers/net/tulip/Kconfig | 14 +-- drivers/net/wan/Kconfig | 24 ++--- drivers/net/wireless/Kconfig | 28 +++--- drivers/parport/Kconfig | 2 drivers/pci/Kconfig | 4 drivers/pci/hotplug/Kconfig | 2 drivers/pcmcia/Kconfig | 8 - drivers/pnp/Kconfig | 2 drivers/pnp/pnpacpi/Kconfig | 2 drivers/pnp/pnpbios/Kconfig | 4 drivers/s390/Kconfig | 2 drivers/scsi/Kconfig | 42 +++++----- drivers/scsi/qla2xxx/Kconfig | 10 +- drivers/serial/Kconfig | 16 +-- drivers/telephony/Kconfig | 4 drivers/usb/Kconfig | 4 drivers/usb/class/Kconfig | 6 - drivers/usb/core/Kconfig | 2 drivers/usb/host/Kconfig | 14 +-- drivers/usb/image/Kconfig | 2 drivers/usb/input/Kconfig | 16 +-- drivers/usb/media/Kconfig | 22 ++--- drivers/usb/misc/Kconfig | 4 drivers/usb/net/Kconfig | 10 +- drivers/usb/serial/Kconfig | 20 ++-- drivers/usb/storage/Kconfig | 4 drivers/video/Kconfig | 50 ++++++------ drivers/video/console/Kconfig | 4 drivers/video/geode/Kconfig | 4 drivers/zorro/Kconfig | 2 fs/Kconfig | 4 fs/ncpfs/Kconfig | 2 fs/nls/Kconfig | 10 +- fs/partitions/Kconfig | 6 - init/Kconfig | 12 +- kernel/power/Kconfig | 6 - net/Kconfig | 8 - net/ax25/Kconfig | 6 - net/decnet/Kconfig | 2 net/ipv4/Kconfig | 24 ++--- net/ipv4/ipvs/Kconfig | 36 ++++---- net/ipv4/netfilter/Kconfig | 12 +- net/ipv6/Kconfig | 12 +- net/ipv6/netfilter/Kconfig | 2 net/ipx/Kconfig | 2 net/irda/Kconfig | 4 net/sched/Kconfig | 48 +++++------ net/sctp/Kconfig | 2 net/xfrm/Kconfig | 2 sound/oss/Kconfig | 16 +-- 117 files changed, 657 insertions(+), 657 deletions(-)
Hi,
Quoted 5 lines · Adrian Bunk
The main reason for this patch (quoting Jesper) is:
Consistency. out of ~4000 help entries in 134Kconfigfiles, 747 of those entries use "---help---" as the keyword, the rest use just "help". So the users of "---help---" are clearly a minority and by renaming them we make things consistent. - I hate inconsistency. :-)
And I still don't like this change...
bye, Roman
Quoted 1 line · Roman Zippel
Hi,
Hi Roman,
Quoted 9 lines · Adrian Bunk
Quoted 6 lines
The main reason for this patch (quoting Jesper) is:
Consistency. out of ~4000 help entries in 134Kconfigfiles, 747 of those entries use "---help---" as the keyword, the rest use just "help". So the users of "---help---" are clearly a minority and by renaming them we make things consistent. - I hate inconsistency. :-)And I still don't like this change...
there's still the point that it's currently used inconsistently.
If you really prefer "---help---" over "help" (I consider "help" being better, but as long as it's used consistently each of them is acceptable), feel free to send a patch instead that changes all occurences of "help" to "---help---".
Quoted 1 line
bye, Roman
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedHi,
Quoted 1 line · Adrian Bunk
there's still the point that it's currently used inconsistently.
Why is it so important to fix this "inconsistency"? Why is it so difficult to accept that both are valid options?
bye, Roman
Quoted 9 lines · Roman Zippel
Hi,
Quoted 1 line · Adrian Bunk
there's still the point that it's currently used inconsistently.
Why is it so important to fix this "inconsistency"? Why is it so difficult to accept that both are valid options?
Let's just let this patch die quietly, ok?
It's not important, I just made it one late evening and submitted it in case it was wanted. It was not wanted so it should just die. No difficulty accepting that.
Signature · 3 lines
Jesper Juhl <[email protected]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html
On Tue, 31 May 2005 19:28:59 +0200 Jesper Juhl wrote:
| On 5/31/05, Roman Zippel <[email protected]> wrote: | > Hi, | > | > On Tue, 31 May 2005, Adrian Bunk wrote: | > | > > there's still the point that it's currently used inconsistently. | > | > Why is it so important to fix this "inconsistency"? | > Why is it so difficult to accept that both are valid options? | > | | Let's just let this patch die quietly, ok? | | It's not important, I just made it one late evening and submitted it | in case it was wanted. It was not wanted so it should just die. No | difficulty accepting that.
I second that.
Thanks.
---
~Randy