Skip to contentSkip to conversation

net/ieee80211/: remove pci.h #include's

PATCH In review Adrian Bunk 2 participants 2 messages May 30, 2005 – May 31, 2005

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 net/ieee80211/: remove pci.h #include's

I was wondering why editing pci.h triggered the rebuild of three files under net/, and as far as I can see, there's no reason for these three files to #include pci.h .

Signed-off-by Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 1 May 2005

 net/ieee80211/ieee80211_module.c |    1 -
 net/ieee80211/ieee80211_rx.c     |    1 -
 net/ieee80211/ieee80211_tx.c     |    1 -
 3 files changed, 3 deletions(-)
net/ieee80211/ieee80211_module.c renamed from net/ieee80211/ieee80211_module.c.old +0 -1
@@ -40,7 +40,6 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/netdevice.h>
-#include <linux/pci.h>
 #include <linux/proc_fs.h>
 #include <linux/skbuff.h>
 #include <linux/slab.h>
net/ieee80211/ieee80211_tx.c renamed from net/ieee80211/ieee80211_tx.c.old +0 -1
@@ -33,7 +33,6 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/netdevice.h>
-#include <linux/pci.h>
 #include <linux/proc_fs.h>
 #include <linux/skbuff.h>
 #include <linux/slab.h>
net/ieee80211/ieee80211_rx.c renamed from net/ieee80211/ieee80211_rx.c.old +0 -1
@@ -23,7 +23,6 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/netdevice.h>
-#include <linux/pci.h>
 #include <linux/proc_fs.h>
 #include <linux/skbuff.h>
 #include <linux/slab.h>
#1 lore raw
Quoted 7 lines · Adrian Bunk

I was wondering why editing pci.h triggered the rebuild of three files under net/, and as far as I can see, there's no reason for these three files to #include pci.h .

 net/ieee80211/ieee80211_module.c |    1 -
 net/ieee80211/ieee80211_rx.c     |    1 -
 net/ieee80211/ieee80211_tx.c     |    1 -

I don't know where these came from since Host AP driver does not include linux/pci.h into the files doing generic IEEE 802.11 processing. Anyway, I have nothing against removing these include lines.

Signature · 1 line
Jouni Malinen                                            PGP id EFC895FA