Skip to contentSkip to conversation

um: copy_from_user size fix in signal.c

PATCH New Domen Puncer 1 participant 1 message Jun 4, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 um: copy_from_user size fix in signal.c

Size of pointer doesn't seem right, but maybe my solution isn't either (sig_size maybe?).

arch/um/sys-i386/signal.c +1 -1
diff -pruNX dontdiff c/arch/um/sys-i386/signal.c a/arch/um/sys-i386/signal.c
@@ -312,7 +312,7 @@ long sys_sigreturn(struct pt_regs regs)
 	unsigned long __user *extramask = frame->extramask;
 	int sig_size = (_NSIG_WORDS - 1) * sizeof(unsigned long);
 
-	if(copy_from_user(&set.sig[0], oldmask, sizeof(&set.sig[0])) ||
+	if(copy_from_user(&set.sig[0], oldmask, sizeof(set.sig[0])) ||
 	   copy_from_user(&set.sig[1], extramask, sig_size))
 		goto segfault;
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors