x64-vmxassist-fix.patch

PATCH In review Arun Sharma 2 participants 2 messages Jun 10, 2005 – Jun 11, 2005

lore

Share & tools

lore

Arun Sharma

author

2005-06-10 22:09 UTC #0 lore raw

PATCH 1/1 x64-vmxassist-fix.patch

Fix 64 bit build.

Signed-off-by Nitin Kamble <[email protected]>

Signed-off-by Arun Sharma <[email protected]>

tools/firmware/vmxassist/head.S +1 -1

@@ -135,7 +135,7 @@
 	.align	4
 	.globl	halt
 halt:
-	pushl	$halt_msg
+	push	$halt_msg
 	call	printf
 #ifdef TEST
         movw    $0x8A00, %dx

Keir Fraser

2005-06-11 05:39 UTC #1 lore raw

Quoted 4 lines · Arun Sharma

Fix 64 bit build.
Signed-off-by Nitin Kamble <[email protected]>
Signed-off-by Arun Sharma <[email protected]>

Surely the correct fix is to put a .code32 at the top of the file? The vmxassist stuff should run in 32-bit protected mode: long mode doesn't necessarily support VM86 mode (not on amd chips I believe).

I think the checked-in fix is benign but not the right run-time fix. :-)

-- Keir