Skip to contentSkip to conversation

Fix large core dumps with a 32-bit off_t

PATCH New Daniel Jacobowitz 1 participant 1 message Jun 13, 2005

Subsystems (2)
VFS exec and binfmt
lore
Share & tools
lore

Daniel Jacobowitz

author
#0 lore raw

PATCH 1/1 Fix large core dumps with a 32-bit off_t

The ELF core dump code has one use of off_t when writing out segments. Some of the segments may be passed the 2GB limit of an off_t, even on a 32-bit system, so it's important to use loff_t instead. This fixes a corrupted core dump in the bigcore test in GDB's testsuite.

Signed-off-by Daniel Jacobowitz <[email protected]>
fs/binfmt_elf.c +1 -1
Index: linux-2.6.11/fs/binfmt_elf.c
===================================================================
@@ -1125,7 +1125,7 @@ static int dump_write(struct file *file,
 	return file->f_op->write(file, addr, nr, &file->f_pos) == nr;
 }
 
-static int dump_seek(struct file *file, off_t off)
+static int dump_seek(struct file *file, loff_t off)
 {
 	if (file->f_op->llseek) {
 		if (file->f_op->llseek(file, off, 0) != off)
Signature · 2 lines
Daniel Jacobowitz
CodeSourcery, LLC