fs/jbd/: possible cleanups
PATCH 1/1 fs/jbd/: possible cleanups
This patch contains the following possible cleanups:
- make needlessly global functions static
- journal.c: remove the unused global function __journal_internal_check and move the check to journal_init
- remove the following write-only global variable:
- journal.c: current_journal
- remove the following unneeded EXPORT_SYMBOL's:
- journal.c: journal_check_used_features
- journal.c: journal_recover
Please check which of these changes do make sense.
Signed-off-by Adrian Bunk <[email protected]>
---
fs/jbd/journal.c | 41 ++++++++++++++++++----------------------- fs/jbd/revoke.c | 3 ++- include/linux/jbd.h | 3 --- 3 files changed, 20 insertions(+), 27 deletions(-)
include/linux/jbd.h renamed from include/linux/jbd.h.old +0 -3
@@ -900,8 +900,6 @@ int start, int len, int bsize);extern journal_t *journal_init_inode (struct inode *);extern int journal_update_format (journal_t *); -extern int journal_check_used_features - (journal_t *,unsigned long ,unsigned long ,unsigned long );extern int journal_check_available_features (journal_t *,unsigned long ,unsigned long ,unsigned long );extern int journal_set_features
@@ -914,7 +912,6 @@extern int journal_skip_recovery (journal_t *);extern void journal_update_superblock (journal_t *,int );extern void __journal_abort_hard (journal_t *); -extern void __journal_abort_soft (journal_t *,int );extern void journal_abort (journal_t *,int );extern int journal_errno (journal_t *);extern void journal_ack_err (journal_t *);
fs/jbd/journal.c renamed from fs/jbd/journal.c.old +18 -23
111 lines not on this page · raw message
fs/jbd/revoke.c renamed from fs/jbd/revoke.c.old +2 -1
@@ -116,7 +116,8 @@ (block << (hash_shift - 12))) & (table->hash_size - 1); } -int insert_revoke_hash (journal_t *journal,unsigned long blocknr,tid_t seq) +static int insert_revoke_hash (journal_t *journal,unsigned long blocknr, +tid_t seq) {struct list_head *hash_list;struct jbd_revoke_record_s *record;