Skip to contentSkip to conversation

fealnx.c calls dev_kfree_skb from atomic context. fix it

PATCH New Denis Vlasenko 1 participant 1 message Jun 17, 2005 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fealnx.c calls dev_kfree_skb from atomic context. fix it

Hi Jeff,

Just a resend. Applies with offset to 2.6.12-rc2
--
vda

I believe I actually saw 'Badness' message because I used wrong function.

No need to check and use exactly matching function, This is not a fast path.

drivers/net/fealnx.c +1 -2
diff -urN linux-2.6.6-bk7.src/drivers/net/fealnx.c linux-2.6.6-bk7-fealnx.src/drivers/net/fealnx.c
@@ -1435,8 +1435,7 @@
 		if (cur->skbuff) {
 			pci_unmap_single(np->pci_dev, cur->buffer,
 				cur->skbuff->len, PCI_DMA_TODEVICE);
-			dev_kfree_skb(cur->skbuff);
-			/* or dev_kfree_skb_irq(cur->skbuff); ? */
+			dev_kfree_skb_any(cur->skbuff);
 			cur->skbuff = NULL;
 		}
 		cur->status = 0;