fs/fscache/: cleanups
PATCH 1/1 fs/fscache/: cleanups
This patch contains the following cleanups:
- make needlessly global code static
- main.c: remove the unused global variable fscache_debug
Signed-off-by Adrian Bunk <[email protected]>
---
This patch was already sent on:
- 23 Apr 2005
fs/fscache/cookie.c | 19 +++++++++++++++---- fs/fscache/fscache-int.h | 11 ----------- fs/fscache/main.c | 2 -- 3 files changed, 15 insertions(+), 17 deletions(-)
fs/fscache/fscache-int.h renamed from fs/fscache/fscache-int.h.old +0 -11
@@ -22,17 +22,6 @@extern void fscache_cookie_init_once (void *_cookie,kmem_cache_t *cachep,unsigned long flags); -extern void __fscache_cookie_put (struct fscache_cookie *cookie); - -static inline void fscache_cookie_put (struct fscache_cookie *cookie) -{ -BUG_ON (atomic_read (&cookie->usage) <=0 ); - -if (atomic_dec_and_test (&cookie->usage)) -__fscache_cookie_put (cookie); - -} -/*****************************************************************************/ /* * debug tracing
fs/fscache/cookie.c renamed from fs/fscache/cookie.c.old +15 -4
@@ -12,14 +12,25 @@#include <linux/module.h> #include "fscache-int.h" -LIST_HEAD (fscache_netfs_list); -LIST_HEAD (fscache_cache_list); -DECLARE_RWSEM (fscache_addremove_sem); +static LIST_HEAD (fscache_netfs_list); +static LIST_HEAD (fscache_cache_list); +static DECLARE_RWSEM (fscache_addremove_sem);kmem_cache_t *fscache_cookie_jar;static void fscache_withdraw_node (struct fscache_cache *cache,struct fscache_node *node); +static void __fscache_cookie_put (struct fscache_cookie *cookie); + + +static inline void fscache_cookie_put (struct fscache_cookie *cookie) +{ +BUG_ON (atomic_read (&cookie->usage) <=0 ); + +if (atomic_dec_and_test (&cookie->usage)) +__fscache_cookie_put (cookie); + +}/*****************************************************************************/ /*
@@ -925,7 +936,7 @@/* * destroy a cookie */ -void __fscache_cookie_put (struct fscache_cookie *cookie) +static void __fscache_cookie_put (struct fscache_cookie *cookie) {struct fscache_search_result *srch;
fs/fscache/main.c renamed from fs/fscache/main.c.old +0 -2
@@ -16,8 +16,6 @@#include <linux/slab.h> #include "fscache-int.h" -int fscache_debug =0 ; -static int fscache_init (void );static void fscache_exit (void );