um: copy_from_user size fix in signal.c
PATCH 1/1 um: copy_from_user size fix in signal.c
From: Domen Puncer <[email protected]>
Size of pointer doesn't seem right, but maybe my solution isn't either (sig_size maybe?).
--- signal.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
arch/um/sys-i386/signal.c +1 -1
@@ -312,7 +312,7 @@ long sys_sigreturn(struct pt_regs regs)unsigned long __user *extramask = frame->extramask;int sig_size = (_NSIG_WORDS -1 ) *sizeof (unsigned long ); -if (copy_from_user (&set.sig[0 ], oldmask,sizeof (&set.sig[0 ])) || +if (copy_from_user (&set.sig[0 ], oldmask,sizeof (set.sig[0 ])) ||copy_from_user (&set.sig[1 ], extramask, sig_size)) goto segfault;
--
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Quoted 5 lines · On Monday 20 June 2005 23:50, [email protected] wrote:
From: Domen Puncer <[email protected]>
Size of pointer doesn't seem right, but maybe my solution isn't either (
sig_sizemaybe?).
Your patch had already been submitted by Jeff a couple of hours before this mail. Thanks!
Quoted 32 lines
Signed-off-by Domen Puncer <[email protected]>--- signal.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)Index:
quilt/arch/um/sys-i386/signal.c
===================================================================arch/um/sys-i386/signal.c +1
-3@@ -312,7 +312,7 @@ long sys_sigreturn(struct pt_regs regs)unsigned long __user *extramask = frame->extramask;int sig_size = (_NSIG_WORDS -1 ) *sizeof (unsigned long ); -if (copy_from_user (&set.sig[0 ], oldmask,sizeof (&set.sig[0 ])) || +if (copy_from_user (&set.sig[0 ], oldmask,sizeof (set.sig[0 ])) ||copy_from_user (&set.sig[1 ], extramask, sig_size)) goto segfault; -- -------------------------------------------------------SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Signature · 23 lines
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click _______________________________________________ User-mode-linux-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Quoted 8 lines · Blaisorblade
Quoted 5 lines · On Monday 20 June 2005 23:50, [email protected] wrote:
From: Domen Puncer <[email protected]>
Size of pointer doesn't seem right, but maybe my solution isn't either (
sig_sizemaybe?).Your patch had already been submitted by Jeff a couple of hours before this mail. Thanks!
And a put it in my dontsend file; another bug to be killed, i guess. Sorry for the noise!
Quoted 7 lines
Quoted 7 lines
Signed-off-by Domen Puncer <[email protected]>--- signal.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)Index:
quilt/arch/um/sys-i386/signal.c
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel