list_for_each_entry: drivers-macintosh-via-pmu.c]
PATCH 1/3 list_for_each_entry: drivers-macintosh-via-pmu.c]
From: Domen Puncer <[email protected]>
Replace for loops with nice list_for_each* macros.
Signed-off-by Domen Puncer <[email protected]>
--- via-pmu.c | 16 ++++------------ 1 files changed, 4 insertions(+), 12 deletions(-)
drivers/macintosh/via-pmu.c +4 -12
@@ -2062,8 +2062,7 @@ pmu_register_sleep_notifier(struct pmu_sstruct list_head *list;struct pmu_sleep_notifier *notifier; -for (list = sleep_notifiers.next; list != &sleep_notifiers; - list = list->next) { +list_for_each (list, &sleep_notifiers) { notifier = list_entry(list, struct pmu_sleep_notifier, list);if (n->priority > notifier->priority)break ;
@@ -2090,8 +2089,7 @@ broadcast_sleep(int when, int fallback)struct list_head *list;struct pmu_sleep_notifier *notifier; -for (list = sleep_notifiers.prev; list != &sleep_notifiers; - list = list->prev) { +list_for_each_prev (list, &sleep_notifiers) { notifier = list_entry(list, struct pmu_sleep_notifier, list); ret = notifier->notifier_call (notifier, when);if (ret !=PBOOK_SLEEP_OK ) {
@@ -2112,14 +2110,10 @@ static int __pmacbroadcast_wake (void) {int ret =PBOOK_SLEEP_OK ; -struct list_head *list;struct pmu_sleep_notifier *notifier; -for (list = sleep_notifiers.next; list != &sleep_notifiers; - list = list->next) { - notifier = list_entry(list, struct pmu_sleep_notifier, list); +list_for_each_entry (notifier, &sleep_notifiers, list) notifier->notifier_call (notifier,PBOOK_WAKE ); - }return ret; }
@@ -2731,15 +2725,13 @@ static void __pmac pmu_pass_intr(unsigned char *data, int len) {struct pmu_private *pp; -struct list_head *list;int i;unsigned long flags;if (len >sizeof (pp->rb_buf[0 ].data)) len =sizeof (pp->rb_buf[0 ].data);spin_lock_irqsave (&all_pvt_lock, flags); -for (list = &all_pmu_pvt; (list = list->next) != &all_pmu_pvt; ) { - pp = list_entry(list, struct pmu_private, list); +list_for_each_entry (pp, &all_pmu_pvt, list) {spin_lock (&pp->lock); i = pp->rb_put +1 ;if (i >=RB_SIZE )
--