Skip to contentSkip to conversation

SMP+irq handling broken in current git?

DISCUSSION Jens Axboe 4 participants 8 messages Jun 23, 2005 – Jun 24, 2005 PCI

lore
Share & tools
lore

Jens Axboe

author
#0 lore raw

Hi,

Something strange is going on with current git as of this morning (head ee98689be1b054897ff17655008c3048fe88be94). On an old test box (dual p3 800MHz), using the same old config I always do on this box has very broken interrupt handling:

[...]

Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
PIIX4: IDE controller at PCI slot 0000:00:04.1
PIIX4: chipset revision 1
PIIX4: not 100% native mode: will probe irqs later

    ide0: BM-DMA at 0xd800-0xd807, BIOS settings: hda:DMA, hdb:DMA
    ide1: BM-DMA at 0xd808-0xd80f, BIOS settings: hdc:DMA, hdd:pio

hda: QUANTUM FIREBALLP AS40.0, ATA DISK drive
hdb: IOMEGA DVDRW8824E2Q-D, ATAPI CD/DVD-ROM drive ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
hdc: IBM-DTLA-307030, ATA DISK drive
ide1 at 0x170-0x177,0x376 on irq 15
irq 14: nobody cared!

 [<c01039e7>] dump_stack+0x17/0x20
 [<c0134ec7>] __report_bad_irq+0x27/0x90
 [<c0134fd2>] note_interrupt+0x72/0x90
 [<c01349cb>] __do_IRQ+0x11b/0x130
 [<c0104f9c>] do_IRQ+0x1c/0x30
 [<c01034ca>] common_interrupt+0x1a/0x20
 [<c0100a9c>] cpu_idle+0x6c/0x80
 [<c040c97a>] start_kernel+0x14a/0x170
 [<c010020e>] 0xc010020e

handlers:
[<c02d12b0>] (ide_intr+0x0/0x150)
Disabling IRQ #14
irq 15: nobody cared!

 [<c01039e7>] dump_stack+0x17/0x20
 [<c0134ec7>] __report_bad_irq+0x27/0x90
 [<c0134fd2>] note_interrupt+0x72/0x90
 [<c01349cb>] __do_IRQ+0x11b/0x130
 [<c0104f9c>] do_IRQ+0x1c/0x30
 [<c01034ca>] common_interrupt+0x1a/0x20
 [<c0100a9c>] cpu_idle+0x6c/0x80
 [<c040c97a>] start_kernel+0x14a/0x170
 [<c010020e>] 0xc010020e

handlers:
[<c02d12b0>] (ide_intr+0x0/0x150)
Disabling IRQ #15
hda: max request size: 128KiB
hda: lost interrupt
hda: lost interrupt
hda: 78177792 sectors (40027 MB) w/1902KiB Cache, CHS=65535/16/63, UDMA(33)
hda: cache flushes not supported
hda:<4>hda: dma_timer_expiry: dma status == 0x64
hda: DMA interrupt recovery
hda: lost interrupt
hda1 hda2 hda3 hda4
hdc: max request size: 128KiB
irq 14: nobody cared!

 [<c01039e7>] dump_stack+0x17/0x20
 [<c0134ec7>] __report_bad_irq+0x27/0x90
 [<c0134fd2>] note_interrupt+0x72/0x90
 [<c01349cb>] __do_IRQ+0x11b/0x130
 [<c0104f9c>] do_IRQ+0x1c/0x30
 [<c01034ca>] common_interrupt+0x1a/0x20
 [<c0100a9c>] cpu_idle+0x6c/0x80
 [<c040c97a>] start_kernel+0x14a/0x170
 [<c010020e>] 0xc010020e

handlers:
[<c02d12b0>] (ide_intr+0x0/0x150)
Disabling IRQ #14
hdc: lost interrupt

Going to UP makes it work just fine for me. Does anyone know what is going on here?!

Signature · 1 line
Jens Axboe
#1 lore raw
Quoted 6 lines · Jens Axboe

Hi,

Something strange is going on with current git as of this morning (head ee98689be1b054897ff17655008c3048fe88be94). On an old test box (dual p3 800MHz), using the same old config I always do on this box has very broken interrupt handling:

Does 2.6.12 work for you?
2.6.11?

I noticed a few "2.6.12 is broken, 2.6.11 works" bug reports with vaguely similar circumstances -- irq handling being a culprit.

Jeff

author
#2 lore raw
Quoted 10 lines · Jeff Garzik
Quoted 6 lines · Jens Axboe

Hi,

Something strange is going on with current git as of this morning (head ee98689be1b054897ff17655008c3048fe88be94). On an old test box (dual p3 800MHz), using the same old config I always do on this box has very broken interrupt handling:

Does 2.6.12 work for you?
2.6.11?

2.6.11 works, 2.6.12 does not.

Quoted 2 lines

I noticed a few "2.6.12 is broken, 2.6.11 works" bug reports with vaguely similar circumstances -- irq handling being a culprit.

One boot kept looping with screaming floppy interrupts, so something has gone really bad there.

Signature · 1 line
Jens Axboe
#3 lore raw
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Jeff Garzik
Quoted 6 lines · Jens Axboe

Hi,

Something strange is going on with current git as of this morning (head ee98689be1b054897ff17655008c3048fe88be94). On an old test box (dual p3 800MHz), using the same old config I always do on this box has very broken interrupt handling:

Quoted 4 lines
Quoted 2 lines

Does 2.6.12 work for you?
2.6.11?

2.6.11 works, 2.6.12 does not.

Do you have any VIA devices? If so, you might try the attached. (Just for debugging; if the patch helps, I have no idea how to do it correctly.)

drivers/pci/quirks.c +1 -1
Index: work/drivers/pci/quirks.c
===================================================================
@@ -510,7 +510,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * PIIX3 USB: We have to disable USB interrupts that are
author
#4 lore raw
Quoted 10 lines · Bjorn Helgaas
Quoted 9 lines · Jens Axboe
Quoted 8 lines · Jeff Garzik
Quoted 6 lines · Jens Axboe

Hi,

Something strange is going on with current git as of this morning (head ee98689be1b054897ff17655008c3048fe88be94). On an old test box (dual p3 800MHz), using the same old config I always do on this box has very broken interrupt handling:

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Does 2.6.12 work for you?
2.6.11?

2.6.11 works, 2.6.12 does not.

Do you have any VIA devices? If so, you might try the attached. (Just for debugging; if the patch helps, I have no idea how to do it correctly.)

No VIA devices, it's an intel board with intel chipset. Do you still want me to test it?

Quoted 13 lines

Index: work/drivers/pci/quirks.c
===================================================================

drivers/pci/quirks.c +1 -1
@@ -510,7 +510,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * PIIX3 USB: We have to disable USB interrupts that are
Signature · 1 line
Jens Axboe
#5 lore raw
Quoted 14 lines · Jens Axboe
Quoted 13 lines · Bjorn Helgaas
Quoted 12 lines · Jens Axboe
Quoted 10 lines · Jeff Garzik
Quoted 6 lines · Jens Axboe

Hi,

Something strange is going on with current git as of this morning (head ee98689be1b054897ff17655008c3048fe88be94). On an old test box (dual p3 800MHz), using the same old config I always do on this box has very broken interrupt handling:

Does 2.6.12 work for you?
2.6.11?

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

2.6.11 works, 2.6.12 does not.

Do you have any VIA devices? If so, you might try the attached. (Just for debugging; if the patch helps, I have no idea how to do it correctly.)

No VIA devices, it's an intel board with intel chipset. Do you still want me to test it?

Nope, I don't think it will make any difference then.

#6 lore raw
In reply to Bjorn Helgaas
Quoted 3 lines · Bjorn Helgaas

Do you have any VIA devices? If so, you might try the attached. (Just for debugging; if the patch helps, I have no idea how to do it correctly.)

The VIA routing is documented in the bridge chipset docs. The older ones are/were on the ftp site. The newer ones are available under NDA or by asking nicely and having a reason.

author
#7 lore raw
In reply to Jeff Garzik
Quoted 8 lines · Jeff Garzik
Quoted 6 lines · Jens Axboe

Hi,

Something strange is going on with current git as of this morning (head ee98689be1b054897ff17655008c3048fe88be94). On an old test box (dual p3 800MHz), using the same old config I always do on this box has very broken interrupt handling:

Quoted 5 lines

Does 2.6.12 work for you?
2.6.11?

I noticed a few "2.6.12 is broken, 2.6.11 works" bug reports with vaguely similar circumstances -- irq handling being a culprit.

To follow up on this on the list, the culprit appears to be the attached string.h update introduced between -rc3 and -rc4. Backing it out makes the kernel work, making it clobber memory (as suggested by Linus) makes it work as well.

The failed test was in mpparse.c, it didn't recognise the pci bus.

Signature · 1 line
Jens Axboe