Skip to contentSkip to conversation

bonding - a trailing whitespace

PATCH In review Carlo Perassi 2 participants 4 messages Jun 23, 2005 – Jun 28, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bonding - a trailing whitespace

A trailing whitespace found making a previuos patch on the same file

---
 drivers/net/bonding/bond_main.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/net/bonding/bond_main.c +1 -1
Index: linux-2.6.12/drivers/net/bonding/bond_main.c
===================================================================
@@ -572,7 +572,7 @@
 static struct proc_dir_entry *bond_proc_dir = NULL;
 #endif
 
-static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, } ;
+static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, };
 static int arp_ip_count;
 static u32 my_ip	= 0;
 static int bond_mode	= BOND_MODE_ROUNDROBIN;

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

drivers/net/bonding/bond_main.c line 575

Quoted 11 lines · Carlo Perassi

A trailing whitespace found making a previuos patch on the same file

---
+++ linux-2.6.12/drivers/net/bonding/bond_main.c

drivers/net/bonding/bond_main.c +1 -1
@@ -572,7 +572,7 @@
 static struct proc_dir_entry *bond_proc_dir = NULL;
 #endif
 
-static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, } ;
+static u32 arp_target[BOND_MAX_ARP_TARGETS] = { 0, };

Why not just

	static u32 arp_target[BOND_MAX_ARP_TARGETS];

... and include in the uninitialize static variables patch?

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Carlo Perassi
Quoted 3 lines

Why not just

	static u32 arp_target[BOND_MAX_ARP_TARGETS];

... and include in the uninitialize static variables patch?

it is already included in
[PATCH] [RESEND] bonding - uninitialize static variables Sat Jun 25 12:05:09 PDT 2005
http://lists.osdl.org/pipermail/kernel-janitors/2005-June/004268.html

Signature · 6 lines
Carlo Perassi - http://www.linux.it/~carlo/

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
#3 lore raw
In reply to Carlo Perassi
Quoted 6 lines · Carlo Perassi
Quoted 3 lines

Why not just

	static u32 arp_target[BOND_MAX_ARP_TARGETS];

... and include in the uninitialize static variables patch?

it is already included in
[PATCH] [RESEND] bonding - uninitialize static variables

Jup, just noticed, sorry.
(Note to self: read mails from bottom up)

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors