CONFIGFS_FS shouldn't be user-visible
PATCH 1/1 CONFIGFS_FS shouldn't be user-visible
I haven't found any reason why CONFIGFS_FS is user-visible. Other parts of the kernel using configfs should simply select it.
fs/Kconfig renamed from fs/Kconfig.old +1 -10
@@ -981,16 +981,7 @@ ramfs. config CONFIGFS_FS - tristate "Userspace-driven configuration filesystem (EXPERIMENTAL)" - depends on EXPERIMENTAL - help - configfs is a ram-based filesystem that provides the converse - of sysfs's functionality. Where sysfs is a filesystem-based - view of kernel objects, configfs is a filesystem-based manager - of kernel objects, or config_items. - - Both sysfs and configfs can and should exist together on the - same system. One is not a replacement for the other. + tristate config RELAYFS_FS tristate "Relayfs file system support"
Quoted 2 lines · Adrian Bunk
I haven't found any reason why
CONFIGFS_FSis user-visible. Other parts of the kernel using configfs should simply select it.
Doesn't work for external modules that might want to use it.
Imagine that configfs gets merged before OCFS2, which depends on it.
Joel
Signature · 12 lines
"There is shadow under this red rock. (Come in under the shadow of this red rock) And I will show you something different from either Your shadow at morning striding behind you Or your shadow at evening rising to meet you. I will show you fear in a handful of dust." Joel Becker Senior Member of Technical Staff Oracle E-mail: [email protected] Phone: (650) 506-8127
PATCH 1/1 CONFIGFS_FS: "If unsure, say N."
Quoted 6 lines · Joel Becker
Quoted 2 lines · Adrian Bunk
I haven't found any reason why
CONFIGFS_FSis user-visible. Other parts of the kernel using configfs should simply select it.Doesn't work for external modules that might want to use it.
Imagine that configfs gets merged before OCFS2, which depends on it.
I was surprised if configfs was merged with zero users in the kernel.
But I get your point, what about the patch below?
Quoted 1 line
Joel
cu
Adrian
<-- snip -->
Make it clear that users usually shouldn't manually enable CONFIGFS_FS.
fs/Kconfig renamed from fs/Kconfig.old +4 -6
@@ -934,13 +934,11 @@ tristate "Userspace-driven configuration filesystem (EXPERIMENTAL)" depends on EXPERIMENTAL help - configfs is a ram-based filesystem that provides the converse - of sysfs's functionality. Where sysfs is a filesystem-based - view of kernel objects, configfs is a filesystem-based manager - of kernel objects, or config_items. + This option is provided for the case where no in-kernel-tree + modules require configfs, but a module built outside the kernel + tree does. Such modules require Y or M here. - Both sysfs and configfs can and should exist together on the - same system. One is not a replacement for the other. + If unsure, say N. config RELAYFS_FS tristate "Relayfs file system support"
Re: [Ocfs2-devel] [-mm patch] CONFIGFS_FS: "If unsure, say N."
Quoted 1 line · Adrian Bunk
But I get your point, what about the patch below?
Non-descriptive. We are descriptive for sysfs (and even allow
the choice!). I'd say that leaving the description but perhaps adding the caveat about modules and unsure-N might be a good way to go.
Joel
Signature · 9 lines
"If you are ever in doubt as to whether or not to kiss a pretty girl,
give her the benefit of the doubt"
-Thomas Carlyle
Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: [email protected]
Phone: (650) 506-8127Re: [Ocfs2-devel] [-mm patch] CONFIGFS_FS: "If unsure, say N."
Quoted 6 lines · Joel Becker
Quoted 1 line · Adrian Bunk
But I get your point, what about the patch below?
Non-descriptive. We are descriptive for sysfs (and even allow
the choice!). I'd say that leaving the description but perhaps adding the caveat about modules and unsure-N might be a good way to go.
The question is:
Assume a user doesn't use external modules, will enabling this option have any effect for him except that it wastes some bytes of his RAM?
sysfs is useful in this case.
How is configfs useful in this case?
Quoted 1 line
Joel
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedRe: [Ocfs2-devel] [-mm patch] CONFIGFS_FS: "If unsure, say N."
Quoted 6 lines · Adrian Bunk
The question is:
Assume a user doesn't use external modules, will enabling this option have any effect for him except that it wastes some bytes of his RAM?sysfs is useful in this case.
How is configfs useful in this case?
I'm not saying it is. I'm saying that "Hey, if you are unsure
you want 'N'" is a good thing to say, but removing the description of "what configfs is" is unhelpful and unneeded.
Joel
Signature · 10 lines
"And yet I fight, And yet I fight this battle all alone. No one to cry to; No place to call home." Joel Becker Senior Member of Technical Staff Oracle E-mail: [email protected] Phone: (650) 506-8127
PATCH 1/1 CONFIGFS_FS: "If unsure, say N."
Quoted 11 lines · Joel Becker
Quoted 6 lines · Adrian Bunk
The question is:
Assume a user doesn't use external modules, will enabling this option have any effect for him except that it wastes some bytes of his RAM?sysfs is useful in this case.
How is configfs useful in this case?I'm not saying it is. I'm saying that "Hey, if you are unsure
you want 'N'" is a good thing to say, but removing the description of "what configfs is" is unhelpful and unneeded.
OK, what about the patch below?
Quoted 1 line
Joel
cu
Adrian
<-- snip -->
Make it clear that users usually shouldn't manually enable CONFIGFS_FS.
fs/Kconfig renamed from fs/Kconfig.old +6 -0
@@ -936,24 +936,30 @@ config CONFIGFS_FS tristate "Userspace-driven configuration filesystem (EXPERIMENTAL)" depends on EXPERIMENTAL help configfs is a ram-based filesystem that provides the converse of sysfs's functionality. Where sysfs is a filesystem-based view of kernel objects, configfs is a filesystem-based manager of kernel objects, or config_items. Both sysfs and configfs can and should exist together on the same system. One is not a replacement for the other. + This option is provided for the case where no in-kernel-tree + modules require configfs, but a module built outside the kernel + tree does. Such modules require Y or M here. + + If unsure, say N. + config RELAYFS_FS tristate "Relayfs file system support" ---help--- Relayfs is a high-speed data relay filesystem designed to provide an efficient mechanism for tools and facilities to relay large amounts of data from kernel space to user space. To compile this code as a module, choose M here: the module will be called relayfs. If unsure, say N.