ide dma blacklist toshiba

PATCH In review maximilian attems 4 participants 9 messages Jun 26, 2005 – Jun 28, 2005

Subsystems (2)

SCSI libata

lore

Share & tools

lore

maximilian attems

author

2005-06-26 17:04 UTC #0 lore raw

PATCH 1/1 ide dma blacklist toshiba

From: Herbert Xu <[email protected]>

blacklist "TOSHIBA CD-ROM XM-1702BC"
bug reporter couldn't acces it's cdrom drive otherwise
debian bug -> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=222939
there are also older reports that this drive doesn't work out of the box:
http://lists.debian.org/debian-boot/1999/02/msg00016.html

Signed-off-by maximilian attems <[email protected]>

drivers/ide/ide-dma.c +1 -0

@@ -125,6 +125,7 @@
 	{ "HITACHI CDR-8335"	,	"ALL"		},
 	{ "HITACHI CDR-8435"	,	"ALL"		},
 	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},
 	{ "CD-532E-A"		,	"ALL"		},
 	{ "E-IDE CD-ROM CR-840",	"ALL"		},
 	{ "CD-ROM Drive/F5A",	"ALL"		},

Jeff Garzik

2005-06-26 17:44 UTC #1 lore raw

drivers/ide/ide-dma.c line 131

Quoted 10 lines · maximilian attems

drivers/ide/ide-dma.c +1 -0

@@ -125,6 +125,7 @@
 	{ "HITACHI CDR-8335"	,	"ALL"		},
 	{ "HITACHI CDR-8435"	,	"ALL"		},
 	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},
 	{ "CD-532E-A"		,	"ALL"		},
 	{ "E-IDE CD-ROM CR-840",	"ALL"		},
 	{ "CD-ROM Drive/F5A",	"ALL"		},

When touching the blacklist, always make sure to patch ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or aonther patch mailed at the same time).

Jeff

maximilian attems

author

2005-06-26 17:48 UTC #2 lore raw

Quoted 19 lines · Jeff Garzik

drivers/ide/ide-dma.c line 131
Quoted 12 lines · maximilian attems
--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05
19:49:28.000000000 +1000
+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05
20:54:34.000000000 +1000
drivers/ide/ide-dma.c +1 -0
@@ -125,6 +125,7 @@
 	{ "HITACHI CDR-8335"	,	"ALL"		},
 	{ "HITACHI CDR-8435"	,	"ALL"		},
 	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},
 	{ "CD-532E-A"		,	"ALL"		},
 	{ "E-IDE CD-ROM CR-840",	"ALL"		},
 	{ "CD-ROM Drive/F5A",	"ALL"		},
When touching the blacklist, always make sure to patch ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or aonther patch mailed at the same time).

Quoted 1 line

Jeff

thanks to pinpoint that.
i'll send in a second patch covering the ata_dma_blacklist[].

--
maks

maximilian attems

2005-06-26 18:00 UTC #3 lore raw

PATCH 1/1 libata dma blacklist toshiba cdrom drive

In reply to Jeff Garzik

blacklist "TOSHIBA CD-ROM XM-1702BC"
bug reporter couldn't acces it's cdrom drive otherwise seperate patch from Herbert Xu adds it to drive_blacklist[] in drivers/ide/ide-dma.c

Signed-off-by maximilian attems <[email protected]>

drivers/scsi/libata-core.c renamed from drivers/scsi/libata-core.c.orig +1 -0

@@ -1920,6 +1920,7 @@ static const char * ata_dma_blacklist []
 	"HITACHI CDR-8335",
 	"HITACHI CDR-8435",
 	"Toshiba CD-ROM XM-6202B",
+	"TOSHIBA CD-ROM XM-1702BC",
 	"CD-532E-A",
 	"E-IDE CD-ROM CR-840",
 	"CD-ROM Drive/F5A",

Jens Axboe

2005-06-27 07:23 UTC #4 lore raw

In reply to Jeff Garzik

Quoted 10 lines · Jeff Garzik

Quoted 9 lines · maximilian attems
--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05
19:49:28.000000000 +1000
+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05
20:54:34.000000000 +1000
drivers/ide/ide-dma.c +1 -0
@@ -125,6 +125,7 @@
 	{ "HITACHI CDR-8335"	,	"ALL"		},
 	{ "HITACHI CDR-8435"	,	"ALL"		},
 	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},

Quoted 8 lines

drivers/ide/ide-dma.c line 131
Quoted 3 lines
drivers/ide/ide-dma.c +0 -0
 	{ "CD-532E-A"		,	"ALL"		},
 	{ "E-IDE CD-ROM CR-840",	"ALL"		},
 	{ "CD-ROM Drive/F5A",	"ALL"		},
When touching the blacklist, always make sure to patch ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or aonther patch mailed at the same time).

This has come up at least two times in the last week already, how about adding a unified dma blacklist to ata.h instead?

Signature · 1 line

Jens Axboe

Jeff Garzik

2005-06-28 04:01 UTC #5 lore raw

Quoted 21 lines · Jens Axboe

Quoted 17 lines · Jeff Garzik
drivers/ide/ide-dma.c line 131
Quoted 12 lines · maximilian attems
--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05
19:49:28.000000000 +1000
+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05
20:54:34.000000000 +1000
drivers/ide/ide-dma.c +1 -0
@@ -125,6 +125,7 @@
 	{ "HITACHI CDR-8335"	,	"ALL"		},
 	{ "HITACHI CDR-8435"	,	"ALL"		},
 	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},
 	{ "CD-532E-A"		,	"ALL"		},
 	{ "E-IDE CD-ROM CR-840",	"ALL"		},
 	{ "CD-ROM Drive/F5A",	"ALL"		},
When touching the blacklist, always make sure to patch ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or aonther patch mailed at the same time).

Quoted 2 lines

This has come up at least two times in the last week already, how about adding a unified dma blacklist to ata.h instead?

Feel free to submit a patch :)

Jeff

Jens Axboe

2005-06-28 06:26 UTC #6 lore raw

Quoted 24 lines · Jeff Garzik

Quoted 23 lines · Jens Axboe
Quoted 19 lines · Jeff Garzik
drivers/ide/ide-dma.c line 131
Quoted 12 lines · maximilian attems
--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05
19:49:28.000000000 +1000
+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05
20:54:34.000000000 +1000
drivers/ide/ide-dma.c +1 -0
@@ -125,6 +125,7 @@
 	{ "HITACHI CDR-8335"	,	"ALL"		},
 	{ "HITACHI CDR-8435"	,	"ALL"		},
 	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},
 	{ "CD-532E-A"		,	"ALL"		},
 	{ "E-IDE CD-ROM CR-840",	"ALL"		},
 	{ "CD-ROM Drive/F5A",	"ALL"		},
When touching the blacklist, always make sure to patch ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or aonther patch mailed at the same time).

Quoted 4 lines

Quoted 2 lines
This has come up at least two times in the last week already, how about adding a unified dma blacklist to ata.h instead?
Feel free to submit a patch :)

Hehe, somehow I knew that was going to be the response :-)

Signature · 1 line

Jens Axboe

maximilian attems

2005-06-28 07:41 UTC #7 lore raw

Quoted 25 lines · Jens Axboe

Quoted 24 lines · Jeff Garzik
Quoted 23 lines · Jens Axboe
Quoted 19 lines · Jeff Garzik
drivers/ide/ide-dma.c line 131
Quoted 12 lines · maximilian attems
--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05
19:49:28.000000000 +1000
+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05
20:54:34.000000000 +1000
drivers/ide/ide-dma.c +1 -0
@@ -125,6 +125,7 @@
 	{ "HITACHI CDR-8335"	,	"ALL"		},
 	{ "HITACHI CDR-8435"	,	"ALL"		},
 	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},
 	{ "CD-532E-A"		,	"ALL"		},
 	{ "E-IDE CD-ROM CR-840",	"ALL"		},
 	{ "CD-ROM Drive/F5A",	"ALL"		},
When touching the blacklist, always make sure to patch ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or aonther patch mailed at the same time).

Quoted 9 lines

Quoted 4 lines
Quoted 2 lines
This has come up at least two times in the last week already, how about adding a unified dma blacklist to ata.h instead?
Feel free to submit a patch :)
Hehe, somehow I knew that was going to be the response :-)
Signature · 1 line
Jens Axboe

if you haven't done it yet, i'll spin one next weekend.

--
maks

Jens Axboe

2005-06-28 07:47 UTC #8 lore raw

Quoted 30 lines · maximilian attems

Quoted 28 lines · Jens Axboe
Quoted 27 lines · Jeff Garzik
Quoted 25 lines · Jens Axboe
Quoted 11 lines · Jeff Garzik
Quoted 9 lines · maximilian attems
--- kernel-source-2.6.6/drivers/ide/ide-dma.c 2004-04-05
19:49:28.000000000 +1000
+++ kernel-source-2.6.6-1/drivers/ide/ide-dma.c 2004-04-05
20:54:34.000000000 +1000
drivers/ide/ide-dma.c +1 -0
@@ -125,6 +125,7 @@
 	{ "HITACHI CDR-8335"	,	"ALL"		},
 	{ "HITACHI CDR-8435"	,	"ALL"		},
 	{ "Toshiba CD-ROM XM-6202B"	,	"ALL"		},
+	{ "TOSHIBA CD-ROM XM-1702BC"	,	"ALL"		},
Quoted 8 lines
drivers/ide/ide-dma.c line 131
Quoted 3 lines
drivers/ide/ide-dma.c +0 -0
 	{ "CD-532E-A"		,	"ALL"		},
 	{ "E-IDE CD-ROM CR-840",	"ALL"		},
 	{ "CD-ROM Drive/F5A",	"ALL"		},
When touching the blacklist, always make sure to patch ata_dma_blacklist[] (drivers/scsi/libata-core.c) in the same patch (or aonther patch mailed at the same time).
This has come up at least two times in the last week already, how about adding a unified dma blacklist to ata.h instead?

Quoted 8 lines

Quoted 6 lines
Quoted 1 line
Feel free to submit a patch :)
Hehe, somehow I knew that was going to be the response :-)
Signature · 1 line
Jens Axboe
if you haven't done it yet, i'll spin one next weekend.

Feel free, thanks.

Signature · 1 line

Jens Axboe