SubmittingPatches - a few more trivialities
PATCH 1/1 SubmittingPatches - a few more trivialities
Reading some detailig about submitting patches I found some strange tabs and a few more trivialities.
--- SubmittingPatches | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-)
SubmittingPatches +7 -7
@@ -291,19 +291,19 @@ person who certified (a), (b) or (c) and I have not modified it. - (d) I understand and agree that this project and the contribution - are public and that a record of the contribution (including all - personal information I submit with it, including my sign-off) is - maintained indefinitely and may be redistributed consistent with - this project or the open source license(s) involved. + (d) I understand and agree that this project and the contribution + are public and that a record of the contribution (including all + personal information I submit with it, including my sign-off) is + maintained indefinitely and may be redistributed consistent with + this project or the open source license(s) involved. then you just add a line saying - Signed-off-by: Random J Developer <[email protected]> + Signed-off-by: Random J Developer <[email protected]> Some people also put extra tags at the end. They'll just be ignored for now, but you can do this to mark internal company procedures or just -point out some special detail about the sign-off. +point out some special detail about the sign-off. -----------------------------------
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
SubmittingPatches
Quoted 12 lines · Carlo Perassi
Reading some detailig about submitting patches I found some strange tabs and a few more trivialities.
Signed-off-by Carlo Perassi <[email protected]>--- SubmittingPatches | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-)Index:
Documentation/SubmittingPatches
===================================================================SubmittingPatches +0
-0
^^ not -p1 appliable. And even when i fix this it doesn't apply.
Quoted 4 lines
SubmittingPatches +0
-0@@ -291,19 +291,19 @@ person who certified (a), (b) or (c) and I have not modified it.
SubmittingPatches line 298
Quoted 10 lines
SubmittingPatches +5
-5- (d) I understand and agree that this project and the contribution - are public and that a record of the contribution (including all - personal information I submit with it, including my sign-off) is - maintained indefinitely and may be redistributed consistent with - this project or the open source license(s) involved. + (d) I understand and agree that this project and the contribution + are public and that a record of the contribution (including all + personal information I submit with it, including my sign-off) is + maintained indefinitely and may be redistributed consistent with + this project or the open source license(s) involved.
What's the reasoning for this? Previous version takes less space.
Quoted 15 lines
SubmittingPatches +2
-2then you just add a line saying - Signed-off-by: Random J Developer <[email protected]> + Signed-off-by: Random J Developer <[email protected]> Some people also put extra tags at the end. They'll just be ignored for now, but you can do this to mark internal company procedures or just -point out some special detail about the sign-off. +point out some special detail about the sign-off. -----------------------------------
Quoted 4 lines
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 1 line
What's the reasoning for this? Previous version takes less space.
a) b) c) are not indented using tabs
Signature · 6 lines
Carlo Perassi - http://www.linux.it/~carlo/ _______________________________________________ Kernel-janitors mailing list [email protected] http://lists.osdl.org/mailman/listinfo/kernel-janitors