Skip to contentSkip to conversation

IBM VSCSI Client: sending client info to server

PATCH In review Linda Xie 3 participants 4 messages Jun 27, 2005 – Jul 6, 2005

Subsystems (3)
SCSI PowerPC IBM Power Virtual SCSI Device Drivers
lore
Share & tools
lore

Linda Xie

author
#0 lore raw

PATCH 1/1 IBM VSCSI Client: sending client info to server

Hi James,

The attached patch fixes the problem in IBM VSCSI Client where the client doesn't send the information which is expected by the server.

Comments are welcome.

If there are no objections, I would like to get this upstream.

Thanks,

Linda Xie
IBM Linux Technology Center

Signed-off-by Linda Xie <[email protected]>
drivers/scsi/ibmvscsi/ibmvscsi.c +1 -3
diff -X ../dontdiff -purN linux-2.6.12-rc5-git10-orig/drivers/scsi/ibmvscsi/ibmvscsi.c madinfo/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -87,7 +87,7 @@ static int max_channel = 3;
 static int init_timeout = 5;
 static int max_requests = 50;
 
-#define IBMVSCSI_VERSION "1.5.5"
+#define IBMVSCSI_VERSION "1.5.6"
 
 MODULE_DESCRIPTION("IBM Virtual SCSI");
 MODULE_AUTHOR("Dave Boutcher");

@@ -675,8 +675,6 @@ static void send_mad_adapter_info(struct
 	struct viosrp_adapter_info *req;
 	struct srp_event_struct *evt_struct;
 	
-	memset(&hostdata->madapter_info, 0x00, sizeof(hostdata->madapter_info));
-	
 	evt_struct = get_event_struct(&hostdata->pool);
 	if (!evt_struct) {
 		printk(KERN_ERR "ibmvscsi: couldn't allocate an event "
drivers/scsi/ibmvscsi/rpa_vscsi.c +51 -0

75 lines not on this page · raw message

drivers/scsi/ibmvscsi/srp.h +2 -0
diff -X ../dontdiff -purN linux-2.6.12-rc5-git10-orig/drivers/scsi/ibmvscsi/srp.h madinfo/drivers/scsi/ibmvscsi/srp.h
@@ -28,6 +28,8 @@
 #ifndef SRP_H
 #define SRP_H
 
+#define SRP_VERSION "16.a"
+
 #define PACKED __attribute__((packed))
 
 enum srp_types {
#1 lore raw
Quoted 8 lines · Linda Xie

Hi James,

The attached patch fixes the problem in IBM VSCSI Client where the client doesn't send
the information which is expected by the server.

Comments are welcome.

Quoted 8 lines

If there are no objections, I would like to get this upstream.

Thanks,

Linda Xie
IBM Linux Technology Center

Signed-off-by Linda Xie <[email protected]>

Ack

Dave Boutcher

#2 lore raw
In reply to Linda Xie

Hi,

Quoted 2 lines

The attached patch fixes the problem in IBM VSCSI Client where the client doesn't send the information which is expected by the server.

...

drivers/scsi/ibmvscsi/rpa_vscsi.c static void ibmvscsi_task(void *data) · line 185

Quoted 1 line
drivers/scsi/ibmvscsi/rpa_vscsi.c +1 -0
+	printk(KERN_INFO "rpa_vscsi: SPR_VERSION: %s\n", SRP_VERSION);

Just a small thing, should the printk say SRP_VERSION?

Anton

author
#3 lore raw
Quoted 12 lines · Anton Blanchard

Hi,

Quoted 3 lines

The attached patch fixes the problem in IBM VSCSI Client where the client doesn't send the information which is expected by the server.

...

Quoted 10 lines

Review

Quoted 3 lines
(quoted diff) +1 -0
+	printk(KERN_INFO "rpa_vscsi: SPR_VERSION: %s\n", SRP_VERSION);

Just a small thing, should the printk say SRP_VERSION?

Anton

Anton, thank you for catching my typo. Attached is an updated version.

Linda

drivers/scsi/ibmvscsi/ibmvscsi.c +1 -3
diff -X ../dontdiff -purN linux-2.6.12-rc5-git10-orig/drivers/scsi/ibmvscsi/ibmvscsi.c madinfo/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -87,7 +87,7 @@ static int max_channel = 3;
 static int init_timeout = 5;
 static int max_requests = 50;
 
-#define IBMVSCSI_VERSION "1.5.5"
+#define IBMVSCSI_VERSION "1.5.6"
 
 MODULE_DESCRIPTION("IBM Virtual SCSI");
 MODULE_AUTHOR("Dave Boutcher");

@@ -675,8 +675,6 @@ static void send_mad_adapter_info(struct
 	struct viosrp_adapter_info *req;
 	struct srp_event_struct *evt_struct;
 	
-	memset(&hostdata->madapter_info, 0x00, sizeof(hostdata->madapter_info));
-	
 	evt_struct = get_event_struct(&hostdata->pool);
 	if (!evt_struct) {
 		printk(KERN_ERR "ibmvscsi: couldn't allocate an event "
drivers/scsi/ibmvscsi/rpa_vscsi.c +51 -0

75 lines not on this page · raw message

drivers/scsi/ibmvscsi/srp.h +2 -0
diff -X ../dontdiff -purN linux-2.6.12-rc5-git10-orig/drivers/scsi/ibmvscsi/srp.h madinfo/drivers/scsi/ibmvscsi/srp.h
@@ -28,6 +28,8 @@
 #ifndef SRP_H
 #define SRP_H
 
+#define SRP_VERSION "16.a"
+
 #define PACKED __attribute__((packed))
 
 enum srp_types {