cleanup-drivers_usb_serial_cypress_m8.patch
drivers/usb/serial/cypress_m8.c
Quoted 10 lines
Reading this driver I noticed some trailing whitespaces and tabs so I removed them with some 80th column fitting and a few more similar things.
drivers/usb/serial/cypress_m8.c +2
-1- tty->termios->c_cflag =B4800 |CS8 |CREAD |HUPCL |CLOCAL ; + tty->termios->c_cflag =B4800 |CS8 |CREAD |HUPCL | +CLOCAL ;
Well, this should be changed to:
tty->termios->c_cflag B4800 | CS8 | CREAD | HUPCL | CLOCAL;
drivers/usb/serial/cypress_m8.c
Quoted 7 lines
drivers/usb/serial/cypress_m8.c +4
-2- tty->termios->c_cflag =B9600 |CS8 |CREAD |HUPCL |CLOCAL ; + tty->termios->c_cflag =B9600 |CS8 |CREAD |HUPCL | +CLOCAL ; - priv->diff_status |= priv->current_status ^ priv->prev_status; + priv->diff_status |= priv->current_status ^ + priv->prev_status;
IMO, better
priv->diff_status | priv->current_status ^ priv->prev_status;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 7 lines · Alexey Dobriyan
Quoted 6 lines
Reading this driver I noticed some trailing whitespaces and tabs so I removed them with some 80th column fitting and a few more similar things.
drivers/usb/serial/cypress_m8.c +0
-0
Quoted 8 lines
drivers/usb/serial/cypress_m8.c
Quoted 3 lines
drivers/usb/serial/cypress_m8.c +2
-1- tty->termios->c_cflag =B4800 |CS8 |CREAD |HUPCL |CLOCAL ; + tty->termios->c_cflag =B4800 |CS8 |CREAD |HUPCL | +CLOCAL ;Well, this should be changed to:
tty->termios->c_cflag = B4800 | CS8 | CREAD | HUPCL | CLOCAL;
Ick, no. Why? We don't inforce the 80 column rule that hard...
But if you really are worried about it try:
tty->termios->c_cflag = B4800 | CS8 | CREAD | HUPCL | CLOCAL;
Which is more readable.
thanks,
greg k-h
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors