Skip to contentSkip to conversation

i386: fix incorrect TSS entry for LDT

PATCH In review Chuck Ebbert 2 participants 2 messages Jul 1, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386: fix incorrect TSS entry for LDT

The LDT entry in the i386 TSS needs to be a selector, not an entry number.

include/asm-i386/processor.h 2005-07-01 00:23:38.666906000 -0400 renamed from include/asm-i386/processor.h 2005-06-30 15:46:17.176906000 -0400 +1 -1
Index: 2.6.13-rc1/include/asm-i386/processor.h
===================================================================
@@ -474,7 +474,7 @@
        .esp0           = sizeof(init_stack) + (long)&init_stack,       \
        .ss0            = __KERNEL_DS,                                  \
        .ss1            = __KERNEL_CS,                                  \
-       .ldt            = GDT_ENTRY_LDT,                                \
+       .ldt            = GDT_ENTRY_LDT * 8,                            \
        .io_bitmap_base = INVALID_IO_BITMAP_OFFSET,                     \
        .io_bitmap      = { [ 0 ... IO_BITMAP_LONGS] = ~0 },            \
 }

--
Chuck

#1 lore raw
Quoted 2 lines · Chuck Ebbert

The LDT entry in the i386 TSS needs to be a selector, not an entry number.

you are right - but this shouldnt really matter, because this TSS field is only loaded by a CPU upon a real TSS switch, which we never do. We load the LDT selector manually, via the lldt instruction (load_LDT*()). (It could at most matter when we do a double-fault, but the TSS of the doublefault handler is set up separately, which has the .ldt field cleared.)

so i'd rather suggest to remove the initialization altogether, as per the (tested) patch below.

Ingo

---

noticed by Chuck Ebbert: the .ldt entry of the TSS was set up incorrectly. It never mattered since this was a leftover from old times, so remove it.

 include/asm-i386/processor.h |    1 -
 1 files changed, 1 deletion(-)
include/asm-i386/processor.h +0 -1
Index: linux/include/asm-i386/processor.h
===================================================================
@@ -474,7 +474,6 @@ struct thread_struct {
 	.esp0		= sizeof(init_stack) + (long)&init_stack,	\
 	.ss0		= __KERNEL_DS,					\
 	.ss1		= __KERNEL_CS,					\
-	.ldt		= GDT_ENTRY_LDT,				\
 	.io_bitmap_base	= INVALID_IO_BITMAP_OFFSET,			\
 	.io_bitmap	= { [ 0 ... IO_BITMAP_LONGS] = ~0 },		\
 }