Skip to contentSkip to conversation

atxp1 module not compiling

PATCH In review Sebastian Pigulak 4 participants 5 messages Jun 30, 2005 – Jul 1, 2005

lore
Share & tools
lore

Sebastian Pigulak

author
#0 lore raw

Hey,

I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:

LD init/built-in.o
LD vmlinux
drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
: undefined reference to i2c_which_vrm' drivers/built-in.o(.text+0x921ae): In function atxp1_attach_adapter':
: undefined reference to `i2c_detect'
make: *** [vmlinux] Błąd 1
==> ERROR: Build Failed. Aborting...

Could someone have a look at the module and possibly fix it up?

----------------------------------------------------------------------
OMNIXMAIL! Jesli masz telefon w sieci Era i dostep do WAP, to mozesz na komorce odbierac poczte ze wszystkich swoich kont poczty e-mail! OMNIXMAIL jest w Era Omnix: http://link.interia.pl/f1896

#1 lore raw

PATCH 1/1 SENSORS_ATXP1 must select I2C_SENSOR

Quoted 1 line · Sebastian Pigulak

Hey,

Hi Sebastian,

Quoted 11 lines

I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:

LD init/built-in.o
LD vmlinux
drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
: undefined reference to i2c_which_vrm' drivers/built-in.o(.text+0x921ae): In function atxp1_attach_adapter':
: undefined reference to `i2c_detect'
make: *** [vmlinux] B??d 1
==> ERROR: Build Failed. Aborting...

Quoted 1 line

Could someone have a look at the module and possibly fix it up?

The patch below should fix it.

cu
Adrian

<-- snip -->

SENSORS_ATXP1 must select I2C_SENSOR.

Signed-off-by Adrian Bunk <[email protected]>
drivers/i2c/chips/Kconfig renamed from drivers/i2c/chips/Kconfig.old +1 -0
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.
author
#2 lore raw

Re: [2.6 patch] SENSORS_ATXP1 must select I2C_SENSOR

Quoted 36 lines · On Fri, 1 Jul 2005 00:17:27 +0200 Adrian Bunk <[email protected]> wrote:
Quoted 1 line · Sebastian Pigulak

Hey,

Hi Sebastian,

Quoted 11 lines

I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:

LD init/built-in.o
LD vmlinux
drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
: undefined reference to i2c_which_vrm' drivers/built-in.o(.text+0x921ae): In function atxp1_attach_adapter':
: undefined reference to `i2c_detect'
make: *** [vmlinux] B??d 1
==> ERROR: Build Failed. Aborting...

Quoted 1 line

Could someone have a look at the module and possibly fix it up?

The patch below should fix it.

cu
Adrian

<-- snip -->

SENSORS_ATXP1 must select I2C_SENSOR.

Signed-off-by Adrian Bunk <[email protected]>

drivers/i2c/chips/Kconfig line 86

Quoted 7 lines
drivers/i2c/chips/Kconfig renamed from drivers/i2c/chips/Kconfig.old +1 -0
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.

Thanks a lot for this patch. Now the kernel compiles just fine.

----------------------------------------------------------------------
Jak powstaje auto? >>> http://link.interia.pl/f1898

#3 lore raw

Re: [2.6 patch] SENSORS_ATXP1 must select I2C_SENSOR

In reply to Adrian Bunk

Hi Adrian,

Quoted 13 lines
Quoted 13 lines

I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:

LD init/built-in.o
LD vmlinux
drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
: undefined reference to i2c_which_vrm' drivers/built-in.o(.text+0x921ae): In function atxp1_attach_adapter': : undefined reference to `i2c_detect'
make: *** [vmlinux] B??d 1
==> ERROR: Build Failed. Aborting...

Quoted 3 lines
Quoted 1 line

Could someone have a look at the module and possibly fix it up?

The patch below should fix it.

Good catch. However, this fix will conflict with a larger patch I am working on (moving hardware monitoring drivers to a different directory [1]), so I applied a different fix on top of my own stack, and will send all this stuff to Greg as soon as possible.

[1] http://lkml.org/lkml/2005/6/27/302

Thanks,

Signature · 1 line
Jean Delvare
#4 lore raw

[PATCH]Re: atxp1 module not compiling; needs I2C_SENSOR

In reply to Sebastian Pigulak
Quoted 13 lines · Sebastian Pigulak

Hey,

I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:

LD init/built-in.o
LD vmlinux
drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
: undefined reference to i2c_which_vrm' drivers/built-in.o(.text+0x921ae): In function atxp1_attach_adapter':
: undefined reference to `i2c_detect'
make: *** [vmlinux] Błąd 1
==> ERROR: Build Failed. Aborting...

Quoted 1 line

Could someone have a look at the module and possibly fix it up?

Try attached patch. (Works fine for me then.)

Cheers,

Prakash

Signed-off-by Prakash Punnoor <[email protected]>
i2c/chips/Kconfig renamed from i2c/chips/Kconfig~ +1 -0
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.
i2c/chips/Kconfig renamed from i2c/chips/Kconfig~ +1 -0
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.