Skip to contentSkip to conversation

I2C: m41t00: fix incorrect kfree

PATCH New Jean Delvare 1 participant 1 message Jul 1, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 I2C: m41t00: fix incorrect kfree

Hi Greg,

Here is a simple path fixing an incorrect kfree in the m41t00 i2c chip driver. The current code happens to work by accident, but the freed pointer isn't the one which was allocated in the first place, which could cause problems later.

Please apply,
thanks.

 drivers/i2c/chips/m41t00.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/chips/m41t00.c +1 -1
@@ -207,7 +207,7 @@
 	int	rc;
 
 	if ((rc = i2c_detach_client(client)) = 0) {
-		kfree(i2c_get_clientdata(client));
+		kfree(client);
 		tasklet_kill(&m41t00_tasklet);
 	}
 	return rc;
Signature · 1 line
Jean Delvare