Skip to contentSkip to conversation

XIP cleanup

MTD Olaf Hering 2 participants 2 messages Jul 12, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 25 lines · Linux Kernel Mailing List

tree d571cdae6507be90d4ee67d4937b765e2b332d77
parent b9c86d595d2a11009c58c84a9a8792aeb4a8f278
author Thomas Gleixner <[email protected]> Thu, 07 Jul 2005 16:50:16 +0200 committer Thomas Gleixner <[email protected]> Thu, 07 Jul 2005 16:50:16 +0200

[MTD] XIP cleanup

Move the architecture dependend code into include/asm/mtd-xip.h

 drivers/mtd/chips/cfi_cmdset_0001.c   |    2 -
 drivers/mtd/chips/cfi_cmdset_0002.c   |    2 -
 include/asm-arm/arch-pxa/mtd-xip.h    |   37 ++++++++++++++++++++++++++++++++++
 include/asm-arm/arch-sa1100/mtd-xip.h |   26 +++++++++++++++++++++++
 include/asm-arm/mtd-xip.h             |   26 +++++++++++++++++++++++
 include/linux/mtd/xip.h               |   31 +++++++++++-----------------
 6 files changed, 104 insertions(+), 20 deletions(-)
include/linux/mtd/xip.h +0 -0
@@ -58,22 +58,16 @@
  * 		returned value is <= the real elapsed time.
  * 	note 2: this should be able to cope with a few seconds without

include/linux/mtd/xip.h line 68

Quoted 10 lines
include/linux/mtd/xip.h +6 -1
  * 		overflowing.
+ *
+ * xip_iprefetch()
+ *  
+ *      Macro to fill instruction prefetch
+ *	e.g. a series of nops:  asm volatile (".rep 8; nop; .endr"); 
  */
 
-#if defined(CONFIG_ARCH_SA1100) || defined(CONFIG_ARCH_PXA)
+#include <asm/mtd-xip.h>

How is that supposed to work?
Should each arch provide their own header file?
Should certion .config options depend on ARM or $FOO?
I assume most of the mtd drivers are not intended for the average Walmart PC.

#2 lore raw
Quoted 5 lines · Olaf Hering

How is that supposed to work?
Should each arch provide their own header file?
Should certion .config options depend on ARM or $FOO?
I assume most of the mtd drivers are not intended for the average Walmart PC.

The dependency on ARM slipped through when I updated the git tree from MTD-CVS.

It's fixed in the MTD git tree.

tglx