char: Add Dell Systems Management Base driver
PATCH 1/1 char: Add Dell Systems Management Base driver
This patch adds the Dell Systems Management Base driver.
The Dell Systems Management Base driver is a character driver that implements ioctls for Dell systems management software to use to communicate with the driver. The driver provides support for Dell systems management software to manage the following Dell PowerEdge
systems: 300, 1300, 1400, 400SC, 500SC, 1500SC, 1550, 600SC, 1600SC, 650, 1655MC, 700, and 750.
By making a contribution to this project, I certify that:
The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file.
---
drivers/char/dcdbas.c +777 -0
@@ -0,0 +1,777 @@ +/* +* dcdbas.c: Dell Systems Management Base Driver +* +* Copyright (C) 1995-2005 Dell Inc. +* +* The Dell Systems Management Base driver is a character driver that +* implements ioctls for Dell systems management software to use to +* communicate with the driver. The driver provides support for Dell +* systems management software to manage the following Dell PowerEdge +* systems: 300, 1300, 1400, 400SC, 500SC, 1500SC, 1550, 600SC, 1600SC, +* 650, 1655MC, 700, and 750. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License v2.0 as published by +* the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +#include <linux/device.h> +#include <linux/dma-mapping.h> +#include <linux/errno.h> +#include <linux/fs.h> +#include <linux/init.h> +#include <linux/ioctl.h> +#include <linux/kernel.h> +#include <linux/mc146818rtc.h> +#include <linux/module.h> +#include <linux/reboot.h> +#include <linux/sched.h> +#include <linux/slab.h> +#include <linux/smp.h> +#include <linux/string.h> +#include <linux/types.h> +#include <asm/io.h> +#include <asm/semaphore.h> +#include <asm/uaccess.h> + +#include "dcdbas.h" + +#define DRIVER_NAME "dcdbas" +#define DRIVER_VERSION "5.6.0-1" +#define DRIVER_DESCRIPTION "Systems Management Base Driver" + +static int driver_major; +static atomic_t hold_on_shutdown; +static struct semaphore tvm_lock; +static u8 *tvm_dma_buf; +static dma_addr_t tvm_dma_buf_handle; +static u32 tvm_dma_buf_phys_addr; +static unsigned int tvm_dma_buf_size; +static u8 tvm_hc_action; +static u8 tvm_smi_type; + +/** +* dcdbas_device_release - device release method +* @dev: device +*/ +static void dcdbas_device_release (struct device *dev) +{ +/* nothing to release */ +} + +static struct platform_device dcdbas_pdev = { + .name =DRIVER_NAME , + .id =-1 , + .dev = { + .coherent_dma_mask =DMA_32BIT_MASK , + .dma_mask = &dcdbas_pdev.dev.coherent_dma_mask, + .release = dcdbas_device_release, + }, +}; + +/** +* tvm_free_dma_buf - free buffer allocated for TVM systems management +*/ +static void tvm_free_dma_buf (void ) +{ +if (tvm_dma_buf ==NULL ) +return ; + +dev_dbg (&dcdbas_pdev.dev,"%s: phys: %x size: %u\n" , + __FUNCTION__, tvm_dma_buf_phys_addr, tvm_dma_buf_size); + +dma_free_coherent (&dcdbas_pdev.dev, tvm_dma_buf_size, tvm_dma_buf, + tvm_dma_buf_handle); + tvm_dma_buf =NULL ; + tvm_dma_buf_handle =0 ; + tvm_dma_buf_phys_addr =0 ; + tvm_dma_buf_size =0 ; +} + +/** +* tvm_realloc_dma_buf - reallocate buffer for TVM systems management if needed +* @size: size of memory needed +*/ +static int tvm_realloc_dma_buf (unsigned int size) +{ +u8 *buf; +dma_addr_t handle; + +if (size >MAX_TVM_DMA_BUF_SIZE ) +return -EINVAL ; + +if (tvm_dma_buf_size >= size) { +if ((size !=0 ) && (tvm_dma_buf ==NULL )) { +dev_dbg (&dcdbas_pdev.dev, +"%s: corruption detected\n" , __FUNCTION__); +return -EFAULT ; + } + +/* current buffer is big enough */ +return 0 ; + } + +/* new buffer is needed */ + buf =dma_alloc_coherent (&dcdbas_pdev.dev, size, &handle,GFP_KERNEL ); +if (buf ==NULL ) { +dev_info (&dcdbas_pdev.dev, +"failed to allocate memory of size %u for TVM\n" , + size); +return -ENOMEM ; + } + +/* free any existing buffer */ +tvm_free_dma_buf (); + +/* set up new buffer for use */ + tvm_dma_buf = buf; + tvm_dma_buf_handle = handle; + tvm_dma_buf_phys_addr = (u32 )virt_to_phys (buf); + tvm_dma_buf_size = size; + +dev_dbg (&dcdbas_pdev.dev,"%s: phys: %x size: %u\n" , + __FUNCTION__, tvm_dma_buf_phys_addr, tvm_dma_buf_size); + +return 0 ; +} + +/** +* tvm_read_dma_buf - read systems management command response from TVM buffer +* @ireq: IOCTL data +*/ +static int tvm_read_dma_buf (struct dcdbas_ioctl_req *ireq) +{ +struct dcdbas_tvm_mem_read *tmr; +struct apm_cmd *apm_cmd; +unsigned int data_size_needed, buf_size_needed; + + data_size_needed =sizeof (struct dcdbas_tvm_mem_read ); +if (ireq->hdr.data_size < data_size_needed) +return -EINVAL ; + + tmr = &ireq->data.tvm_mem_read; +dev_dbg (&dcdbas_pdev.dev,"%s: size: %u\n" , __FUNCTION__, tmr->size); +if (tmr->size <ESM_APM_CMD_HEADER_SIZE || + tmr->size >MAX_DCDBAS_IOCTL_DATA_SIZE ) +return -EINVAL ; + + data_size_needed =sizeof (struct dcdbas_tvm_mem_read ) - +sizeof (tmr->buffer) + + tmr->size; +if (ireq->hdr.data_size < data_size_needed) +return -EINVAL ; + +if (tvm_dma_buf ==NULL || + tvm_dma_buf_size <ESM_APM_CMD_HEADER_SIZE ) { + ireq->hdr.status =ESM_STATUS_CMD_DEVICE_BAD ; +return 0 ; + } + + apm_cmd = (struct apm_cmd *)tvm_dma_buf; + + buf_size_needed = tmr->size; +if (apm_cmd->command &ESM_APM_LONG_CMD_FORMAT ) + buf_size_needed += + (sizeof (struct apm_cmd ) -ESM_APM_CMD_HEADER_SIZE ); + +if (tvm_dma_buf_size < buf_size_needed) { + ireq->hdr.status =ESM_STATUS_CMD_DEVICE_BAD ; +return 0 ; + } + +if (apm_cmd->command &ESM_APM_LONG_CMD_FORMAT ) { +/* long command */ +memcpy (tmr->buffer, tvm_dma_buf,ESM_APM_CMD_HEADER_SIZE ); +if (tmr->size >ESM_APM_CMD_HEADER_SIZE ) { +memcpy (tmr->buffer +ESM_APM_CMD_HEADER_SIZE , + tvm_dma_buf +sizeof (struct apm_cmd ), + tmr->size -ESM_APM_CMD_HEADER_SIZE ); + } + }else { +/* short command */ +memcpy (tmr->buffer, tvm_dma_buf, tmr->size); + } + + ireq->hdr.status =ESM_STATUS_CMD_SUCCESS ; +return 0 ; +} + +/** +* tvm_write_dma_buf - write systems management command request to TVM buffer +* @ireq: IOCTL data +*/ +static int tvm_write_dma_buf (struct dcdbas_ioctl_req *ireq) +{ +struct dcdbas_tvm_mem_write *tmw; +struct apm_cmd *apm_cmd; +unsigned int data_size_needed, buf_size_needed; +int ret; + + data_size_needed =sizeof (struct dcdbas_tvm_mem_write ); +if (ireq->hdr.data_size < data_size_needed) +return -EINVAL ; + + tmw = &ireq->data.tvm_mem_write; +dev_dbg (&dcdbas_pdev.dev,"%s: size: %u\n" , __FUNCTION__, tmw->size); +if (tmw->size <ESM_APM_CMD_HEADER_SIZE || + tmw->size >MAX_DCDBAS_IOCTL_DATA_SIZE ) +return -EINVAL ; + + data_size_needed =sizeof (struct dcdbas_tvm_mem_write ) - +sizeof (tmw->buffer) + + tmw->size; +if (ireq->hdr.data_size < data_size_needed) +return -EINVAL ; + + apm_cmd = (struct apm_cmd *)tmw->buffer; + buf_size_needed = tmw->size; +if (apm_cmd->command &ESM_APM_LONG_CMD_FORMAT ) + buf_size_needed += + (sizeof (struct apm_cmd ) -ESM_APM_CMD_HEADER_SIZE ); + +/* make sure buffer is big enough for command */ + ret =tvm_realloc_dma_buf (buf_size_needed); +if (ret) +return ret; + +if (apm_cmd->command &ESM_APM_LONG_CMD_FORMAT ) { +/* long command */ +memcpy (tvm_dma_buf, tmw->buffer,ESM_APM_CMD_HEADER_SIZE ); +if (tmw->size >ESM_APM_CMD_HEADER_SIZE ) { +memcpy (tvm_dma_buf +sizeof (struct apm_cmd ), + tmw->buffer +ESM_APM_CMD_HEADER_SIZE , + tmw->size -ESM_APM_CMD_HEADER_SIZE ); + } + +/* create scatter/gather list */ + apm_cmd = (struct apm_cmd *)tvm_dma_buf; + apm_cmd->parameters.longreq.num_sg_entries =1 ; + apm_cmd->parameters.longreq.sglist[0 ].size = + (tmw->size -ESM_APM_CMD_HEADER_SIZE ); + apm_cmd->parameters.longreq.sglist[0 ].addr = + (tvm_dma_buf_phys_addr +sizeof (struct apm_cmd )); + }else { +/* short command */ +memcpy (tvm_dma_buf, tmw->buffer, tmw->size); + } + + tmw->phys_address = tvm_dma_buf_phys_addr; + + ireq->hdr.status =ESM_STATUS_CMD_SUCCESS ; +return 0 ; +} + +/** +* tvm_alloc_dma_buf - allocate buffer for TVM systems management +* @ireq: IOCTL data +*/ +static int tvm_alloc_dma_buf (struct dcdbas_ioctl_req *ireq) +{ +struct dcdbas_tvm_mem_alloc *tma; +int ret; + +if (ireq->hdr.data_size <sizeof (struct dcdbas_tvm_mem_alloc )) +return -EINVAL ; + + tma = &ireq->data.tvm_mem_alloc; +dev_dbg (&dcdbas_pdev.dev,"%s: size: %u\n" , __FUNCTION__, tma->size); + + ret =tvm_realloc_dma_buf (tma->size); +if (ret) +return ret; + + tma->phys_address = tvm_dma_buf_phys_addr; + + ireq->hdr.status =ESM_STATUS_CMD_SUCCESS ; +return 0 ; +} + +/** +* tvm_set_hc_action - set TVM system host control action +* @ireq: IOCTL data +*/ +static int tvm_set_hc_action (struct dcdbas_ioctl_req *ireq) +{ +struct dcdbas_tvm_hc_action *thca; +int ret; + +if (ireq->hdr.data_size <sizeof (struct dcdbas_tvm_hc_action )) +return -EINVAL ; + +/* make sure buffer is available for host control command */ + ret =tvm_realloc_dma_buf (sizeof (struct apm_cmd )); +if (ret) +return ret; + + thca = &ireq->data.tvm_hc_action; +dev_dbg (&dcdbas_pdev.dev,"%s: action_bitmap: %x smi_type: %u\n" , + __FUNCTION__, thca->action_bitmap, thca->smi_type); + + tvm_hc_action = thca->action_bitmap; + tvm_smi_type = thca->smi_type; + + ireq->hdr.status =ESM_STATUS_CMD_SUCCESS ; +return 0 ; +} + +/** +* tvm_perform_cmd - perform command for TVM systems management +* +* The caller must set up the command in tvm_dma_buf. +*/ +static s32 tvm_perform_cmd (void ) +{ +struct apm_cmd *apm_cmd; +u8 *data; +unsigned long flags; +u32 num_ticks; +s8 cmd_status; +u8 index; + + apm_cmd = (struct apm_cmd *)tvm_dma_buf; + apm_cmd->status =ESM_STATUS_CMD_UNSUCCESSFUL ; + +switch (tvm_smi_type) { +case TVM_SMITYPE_TYPE1 : + { + cmd_status =ESM_STATUS_CMD_UNSUCCESSFUL ; + data = (u8 *)&tvm_dma_buf_phys_addr; + +/* write physical address one byte at a time */ +spin_lock_irqsave (&rtc_lock, flags); +for (index =PE1300_CMOS_CMD_STRUCT_PTR ; + index < (PE1300_CMOS_CMD_STRUCT_PTR +4 ); + index++) { +outb (index, + (CMOS_BASE_PORT +CMOS_PAGE2_INDEX_PORT_PIIX4 )); +outb (*data++, + (CMOS_BASE_PORT +CMOS_PAGE2_DATA_PORT_PIIX4 )); + } +spin_unlock_irqrestore (&rtc_lock, flags); + +/* first set status to -1 as called by spec */ +outb ((u8 )cmd_status,PCAT_APM_STATUS_PORT ); + +/* generate SMM call */ +outb (ESM_APM_CMD ,PCAT_APM_CONTROL_PORT ); + +/* restore RTC index pointer */ +spin_lock_irqsave (&rtc_lock, flags); +outb (0x0C ,0x70 ); +inb (0x70 ); +spin_unlock_irqrestore (&rtc_lock, flags); + +/* wait a few to see if it executed */ + num_ticks =TIMEOUT_USEC_SHORT_SEMA_BLOCKING ; +while ((cmd_status =inb (PCAT_APM_STATUS_PORT )) + ==ESM_STATUS_CMD_UNSUCCESSFUL ) { + num_ticks--; +if (num_ticks ==EXPIRED_TIMER ) +return ESM_STATUS_CMD_TIMEOUT ; + } + } +break ; + +case TVM_SMITYPE_TYPE2 : +case TVM_SMITYPE_TYPE3 : + { + data = (u8 *)&tvm_dma_buf_phys_addr; + +/* write physical address one byte at a time */ +spin_lock_irqsave (&rtc_lock, flags); +for (index =PE1400_CMOS_CMD_STRUCT_PTR ; + index < (PE1400_CMOS_CMD_STRUCT_PTR +4 ); + index++) { +outb (index, (CMOS_BASE_PORT +CMOS_PAGE1_INDEX_PORT )); +outb (*data++, (CMOS_BASE_PORT +CMOS_PAGE1_DATA_PORT )); + } +spin_unlock_irqrestore (&rtc_lock, flags); + +/* generate SMM call */ +if (tvm_smi_type ==TVM_SMITYPE_TYPE3 ) +outb (ESM_APM_CMD ,PCAT_APM_CONTROL_PORT ); +else +outb (ESM_APM_CMD ,PE1400_APM_CONTROL_PORT ); + +/* restore RTC index pointer */ +spin_lock_irqsave (&rtc_lock, flags); +outb (0x0C ,0x70 ); +inb (0x70 ); +spin_unlock_irqrestore (&rtc_lock, flags); + +/* read control port back to serialize write */ + cmd_status =inb (PE1400_APM_CONTROL_PORT ); + +/* wait a few to see if it executed */ + num_ticks =TIMEOUT_USEC_SHORT_SEMA_BLOCKING ; +while (apm_cmd->status ==ESM_STATUS_CMD_UNSUCCESSFUL ) { + num_ticks--; +if (num_ticks ==EXPIRED_TIMER ) +return ESM_STATUS_CMD_TIMEOUT ; + } + } +break ; + +default : +return ESM_STATUS_CMD_NOT_IMPLEMENTED ; + } + +return ESM_STATUS_CMD_SUCCESS ; +} + +/** +* tvm_host_control - initiate host control action on TVM system +*/ +static s32 tvm_host_control (void ) +{ +struct apm_cmd *apm_cmd; + +if (tvm_dma_buf ==NULL || + tvm_dma_buf_size <sizeof (struct apm_cmd )) { +dev_dbg (&dcdbas_pdev.dev,"%s: TVM buffer error\n" , + __FUNCTION__); +return ESM_STATUS_CMD_DEVICE_BAD ; + } + + apm_cmd = (struct apm_cmd *)tvm_dma_buf; + +/* power off takes precedence */ +if (tvm_hc_action &HC_ACTION_HOST_CONTROL_POWEROFF ) { + tvm_hc_action =HC_ACTION_NONE ; + + apm_cmd->command =ESM_APM_POWER_CYCLE ; + apm_cmd->reserved =0 ; + *((s16 *)&apm_cmd->parameters.shortreq.parm[0 ]) = (s16 )0 ; + +return tvm_perform_cmd (); + } +if (tvm_hc_action &HC_ACTION_HOST_CONTROL_POWERCYCLE ) { + tvm_hc_action =HC_ACTION_NONE ; + + apm_cmd->command =ESM_APM_POWER_CYCLE ; + apm_cmd->reserved =0 ; + *((s16 *)&apm_cmd->parameters.shortreq.parm[0 ]) = (s16 )20 ; + +return tvm_perform_cmd (); + } + + tvm_hc_action =HC_ACTION_NONE ; + +return ESM_STATUS_CMD_UNSUCCESSFUL ; +} + +/** +* callintf_generate_smi - generate SMI for calling interface request +* @ireq: IOCTL data +*/ +static int callintf_generate_smi (struct dcdbas_ioctl_req *ireq) +{ +#if defined(__i386__) +struct dcdbas_callintf_cmd *ci_cmd; +u32 command_buffer_phys_addr; +cpumask_t old_mask; + +if (ireq->hdr.data_size <sizeof (struct dcdbas_callintf_cmd )) +return -EINVAL ; + + ci_cmd = &ireq->data.callintf_cmd; + command_buffer_phys_addr =virt_to_phys (ci_cmd->command_buffer); + +dev_dbg (&dcdbas_pdev.dev,"%s: cmdaddr: %x cmdcode: %x phys: %x\n" , + __FUNCTION__, ci_cmd->command_address, ci_cmd->command_code, + command_buffer_phys_addr); + +/* SMI requires CPU 0 */ + old_mask = current->cpus_allowed; +set_cpus_allowed (current,cpumask_of_cpu (0 )); +if (smp_processor_id () !=0 ) { +dev_dbg (&dcdbas_pdev.dev,"%s: failed to get CPU 0\n" , + __FUNCTION__); +return -EBUSY ; + } + +/* +* SMI requires command buffer physical address in ebx and +* signature in ecx. +*/ + +/* generate SMI */ + asm("outb %b0,%w1" : : +"a" (ci_cmd->command_code), +"d" (ci_cmd->command_address), +"b" (command_buffer_phys_addr), +"c" (ci_cmd->signature)); + +set_cpus_allowed (current, old_mask); + ireq->hdr.status =ESM_STATUS_CMD_SUCCESS ; +return 0 ; +#else +return -ENOSYS ; +#endif +} + +/** +* dcdbas_host_control - initiate host control action +*/ +static void dcdbas_host_control (void ) +{ +if (tvm_hc_action !=HC_ACTION_NONE ) +tvm_host_control (); +} + +/** +* dcdbas_dispatch_ioctl - dispatch IOCTL request +* @ireq: IOCTL request +*/ +static int dcdbas_dispatch_ioctl (struct dcdbas_ioctl_req *ireq) +{ +int retval =0 ; + +dev_dbg (&dcdbas_pdev.dev,"%s: req_type: %u\n" , + __FUNCTION__, ireq->hdr.req_type); + +switch (ireq->hdr.req_type) { +case ESM_TVM_READ_MEM : +if (down_interruptible (&tvm_lock)) +return -ERESTARTSYS ; + retval =tvm_read_dma_buf (ireq); +up (&tvm_lock); +break ; + +case ESM_TVM_WRITE_MEM : +if (down_interruptible (&tvm_lock)) +return -ERESTARTSYS ; + retval =tvm_write_dma_buf (ireq); +up (&tvm_lock); +break ; + +case ESM_TVM_ALLOC_MEM : +if (down_interruptible (&tvm_lock)) +return -ERESTARTSYS ; + retval =tvm_alloc_dma_buf (ireq); +up (&tvm_lock); +break ; + +case ESM_TVM_HC_ACTION : +if (down_interruptible (&tvm_lock)) +return -ERESTARTSYS ; + retval =tvm_set_hc_action (ireq); +up (&tvm_lock); +break ; + +case ESM_CALLINTF_REQ : + retval =callintf_generate_smi (ireq); +break ; + +case ESM_HOLD_OS_ON_SHUTDOWN : +/* firmware is going to perform host control action */ +atomic_set (&hold_on_shutdown,1 ); + ireq->hdr.status =ESM_STATUS_CMD_SUCCESS ; +break ; + +case ESM_CANCEL_HOLD_OS_ON_SHUTDOWN : +atomic_set (&hold_on_shutdown,0 ); + ireq->hdr.status =ESM_STATUS_CMD_SUCCESS ; +break ; + +default : +dev_dbg (&dcdbas_pdev.dev,"%s: unsupported req_type\n" , + __FUNCTION__); + ireq->hdr.status =ESM_STATUS_CMD_NOT_IMPLEMENTED ; +break ; + } + +return retval; +} + +/** +* dcdbas_do_ioctl - process ioctl request +* @filp: file object for device +* @cmd: IOCTL command +* @arg: IOCTL request data +*/ +static int dcdbas_do_ioctl (struct file *filp,unsigned int cmd, +unsigned long arg) +{ +struct dcdbas_ioctl_req __user *ubuf; +struct dcdbas_ioctl_req *kbuf; +struct dcdbas_ioctl_hdr hdr; +unsigned long size; +int ret; + +if (cmd !=IOCTL_DCDBAS_CMD ) { + ret = -EINVAL ; + goto out1; + } + + ubuf = (struct dcdbas_ioctl_req __user *)arg; +if (copy_from_user (&hdr, ubuf,sizeof (struct dcdbas_ioctl_hdr ))) { + ret = -EFAULT ; + goto out1; + } + +if (hdr.data_size >MAX_DCDBAS_IOCTL_DATA_SIZE ) { + ret = -EINVAL ; + goto out1; + } + + size =sizeof (struct dcdbas_ioctl_hdr ) + hdr.data_size; +if ((kbuf =kmalloc (size,GFP_KERNEL )) ==NULL ) { +dev_info (&dcdbas_pdev.dev, +"failed to allocate ioctl memory size %lu\n" , + size); + ret = -ENOMEM ; + goto out1; + } + +if (copy_from_user (kbuf, ubuf, size)) { + ret = -EFAULT ; + goto out2; + } + +if ((ret =dcdbas_dispatch_ioctl (kbuf)) !=0 ) + goto out2; + +if (copy_to_user (ubuf, kbuf, size)) + ret = -EFAULT ; + +out2: +kfree (kbuf); +out1: +return ret; +} + +/** +* dcdbas_ioctl - ioctl handler +* @inode: inode for device +* @filp: file object for device +* @cmd: IOCTL command +* @arg: IOCTL request data +*/ +static int dcdbas_ioctl (struct inode *inode,struct file *filp, +unsigned int cmd,unsigned long arg) +{ +return dcdbas_do_ioctl (filp, cmd, arg); +} + +/** +* dcdbas_compat_ioctl - compat ioctl handler +* @filp: file object for device +* @cmd: IOCTL command +* @arg: IOCTL request data +*/ +static long dcdbas_compat_ioctl (struct file *filp,unsigned int cmd, +unsigned long arg) +{ +return dcdbas_do_ioctl (filp, cmd, arg); +} + +/** +* dcdbas_reboot_notify - handle reboot notification +* @nb: info about registered reboot notifier +* @code: notification code +* @unused: unused argument +*/ +static int dcdbas_reboot_notify (struct notifier_block *nb,unsigned long code, +void *unused) +{ +static unsigned int notify_cnt =0 ; + +switch (code) { +case SYS_DOWN : +case SYS_HALT : +case SYS_POWER_OFF : +if (atomic_read (&hold_on_shutdown)) { +/* firmware is going to perform host control action */ +if (++notify_cnt ==2 ) { +printk (KERN_WARNING +"Please wait for shutdown " +"action to complete...\n" ); +dcdbas_host_control (); + } +/* +* register again and initiate the host control +* action on the second notification to allow +* everyone that registered to be notified +*/ +register_reboot_notifier (nb); + } +break ; + } + +return NOTIFY_DONE ; +} + +static struct file_operations dcdbas_fops = { + .owner =THIS_MODULE , + .ioctl = dcdbas_ioctl, + .compat_ioctl = dcdbas_compat_ioctl, +}; + +static struct notifier_block dcdbas_reboot_nb = { + .notifier_call = dcdbas_reboot_notify, + .next =NULL , + .priority =0 +}; + +/** +* dcdbas_init - initialize driver +*/ +static int __init dcdbas_init (void ) +{ +int ret; + + tvm_hc_action =HC_ACTION_NONE ; + tvm_smi_type =TVM_SMITYPE_NONE ; +sema_init (&tvm_lock,1 ); + + ret =platform_device_register (&dcdbas_pdev); +if (ret) + goto error1; + + ret =register_chrdev (0 ,DRIVER_NAME , &dcdbas_fops); +if (ret <0 ) { +dev_warn (&dcdbas_pdev.dev, +"register_chrdev failed with error %d\n" , + ret); + goto error2; + } + driver_major = ret; + +register_reboot_notifier (&dcdbas_reboot_nb); + +dev_info (&dcdbas_pdev.dev,"%s (version %s)\n" , +DRIVER_DESCRIPTION ,DRIVER_VERSION ); + +return 0 ; + +error2: +platform_device_unregister (&dcdbas_pdev); +error1: +return ret; +} + +/** +* dcdbas_exit - perform driver cleanup +*/ +static void __exit dcdbas_exit(void) +{ +unregister_reboot_notifier (&dcdbas_reboot_nb); +unregister_chrdev (driver_major,DRIVER_NAME ); +platform_device_unregister (&dcdbas_pdev); +tvm_free_dma_buf (); +} + +module_init (dcdbas_init); +module_exit (dcdbas_exit); + +MODULE_DESCRIPTION (DRIVER_DESCRIPTION " (version " DRIVER_VERSION ")" ); +MODULE_VERSION (DRIVER_VERSION ); +MODULE_AUTHOR ("Dell Inc." ); +MODULE_LICENSE ("GPL" ); +
drivers/char/dcdbas.h +163 -0
163 lines not on this page · raw message
drivers/char/Kconfig +17 -0
@@ -1002,5 +1002,22 @@ config MMTIMER source "drivers/char/tpm/Kconfig" +menu "Dell Systems Management" + +config DCDBAS + tristate "Dell Systems Management Base driver" + default m + help + The Dell Systems Management Base driver provides support for + Dell systems management software to manage the following Dell + PowerEdge systems: 300, 1300, 1400, 400SC, 500SC, 1500SC, 1550, + 600SC, 1600SC, 650, 1655MC, 700, and 750. + + Say Y or M here if you plan to use Dell systems management + software to manage one of the systems listed above. If you + say M here, the driver will be compiled as a module called dcdbas. + +endmenu + endmenu
drivers/char/Makefile +2 -0
@@ -92,6 +92,8 @@ obj-$(CONFIG_IPMI_HANDLER) += ipmi/ obj-$(CONFIG_HANGCHECK_TIMER) += hangcheck-timer.o obj-$(CONFIG_TCG_TPM) += tpm/ +obj-$(CONFIG_DCDBAS) += dcdbas.o + # Files generated that shall be removed upon make clean clean-files := consolemap_deftbl.c defkeymap.c qtronixmap.c
MAINTAINERS +5 -0
@@ -692,6 +692,11 @@ M: [email protected] W: http://www.debian.org/~dz/i8k/ S: Maintained +DELL SYSTEMS MANAGEMENT BASE DRIVER (dcdbas) +P: Doug Warzecha +M: [email protected] +S: Maintained + DEVICE-MAPPER P: Alasdair Kergon L: [email protected]
Quoted 1 line · Doug Warzecha
This patch adds the Dell Systems Management Base driver.
You keep posting this driver without explaining/showing how it's used. Could you perhaps give some more details here please?
Quoted 6 lines · Chris Wedgwood
Quoted 1 line · Doug Warzecha
This patch adds the Dell Systems Management Base driver.
You keep posting this driver without explaining/showing how it's used. Could you perhaps give some more details here please?
Here's some more information on the driver and the systems that it supports. Because the hardware interfaces on those systems and the Dell systems management software that access the interfaces are proprietary, I can't provide specifications for the interfaces or source code for the software.
The systems that are supported by the dcdbas driver contain the following Dell proprietary hardware systems management interfaces: Temperature Voltage Monitor (TVM) and Calling Interface. These interfaces are supported by older Dell PowerEdge systems. The latest shipping PowerEdge systems support the standard IPMI hardware systems management interface which can be accessed by the in-kernel standard IPMI driver on Linux. Future PowerEdge systems are expected to support the IPMI systems management interface as well.
The Dell TVM and Calling Interface interfaces are accessed through the use of Systems Management Interrupts. The dcdbas driver acts primarily as a pass-through mechanism for Dell systems management software to generate those interrupts. Dell systems management software (which is proprietary) loads and uses the driver if it is needed. The dcdbas driver provides access to the TVM and Calling Interface systems management interfaces through the use of ioctls.
Here is a brief description of each ioctl request that is supported:
ESM_TVM_ALLOC_MEM - used to allocate a buffer for systems management requests on systems that contain the TVM systems management interface. The physical address of the buffer is needed to generate the request.
ESM_TVM_WRITE_MEM - used to put systems management request data in the TVM buffer. After this is done, Dell systems management software generates the request.
ESM_TVM_READ_MEM - used to get systems management response data from the TVM buffer after the systems management request has completed.
ESM_CALLINTF_REQ - used to generate a systems management request on systems that contain the Calling Interface systems management interface.
ESM_TVM_HC_ACTION - used to tell the driver what host control action to perform on systems that contain the TVM systems management interface.
ESM_HOLD_OS_ON_SHUTDOWN - used to tell the driver to perform the previously set host control action when it is notified that the OS has finished shutting down. Dell systems management software initiates the OS shutdown after this request.
ESM_CANCEL_HOLD_OS_ON_SHUTDOWN - used to cancel ESM_HOLD_OS_ON_SHUTDOWN if the systems management software encounters a problem in the host control process.
Hi!
Please use enter key every 70 chars or so...
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
This patch adds the Dell Systems Management Base driver.
You keep posting this driver without explaining/showing how it's used. Could you perhaps give some more details here please?
Here's some more information on the driver and the systems that it supports. Because the hardware interfaces on those systems and the Dell systems management software that access the interfaces are proprietary, I can't provide specifications for the interfaces or source code for the software.
So... instead of providing nice & standard interface, you invent very ugly interface that allows your usermode app to band on SMI directly -- because you don't want to tell us how to drive SMI.
No, sorry. Provide something with standard interface (like lm_sensors use). You'll have to tell us how to control the hardware. Its temperature sensor; I don't see how that is worh calling "proprietary"...
Pavel
Signature · 1 line
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
Quoted 4 lines · Doug Warzecha
Because the hardware interfaces on those systems and the Dell systems management software that access the interfaces are proprietary, I can't provide specifications for the interfaces or source code for the software.
So you want a driver merged which nobody except Dell can write code for?
Quoted 4 lines
The systems that are supported by the dcdbas driver contain the following Dell proprietary hardware systems management interfaces:
Temperature Voltage Monitor (TVM) and Calling Interface. These interfaces are supported by older Dell PowerEdge systems.
What's so special here that you can't give more details? I personally find it a little unfair to ask to have a driver merged into mainline to facilitate some proprietary userland where you refuse to give protocol level details to create a viable alternative.
On Tue, 5 Jul 2005 19:13:34 -0500 Doug Warzecha wrote:
| This patch adds the Dell Systems Management Base driver. | | The Dell Systems Management Base driver is a character driver that | implements ioctls for Dell systems management software to use to | communicate with the driver. The driver provides support for Dell | systems management software to manage the following Dell PowerEdge | systems: 300, 1300, 1400, 400SC, 500SC, 1500SC, 1550, 600SC, 1600SC, | 650, 1655MC, 700, and 750. | | By making a contribution to this project, I certify that: | The contribution was created in whole or in part by me and | I have the right to submit it under the open source license | indicated in the file.
Could you possibly reply to some earlier comments that have been posted from Chris Wedgwood and me (and possibly others) instead of ignoring them?
e.g.,
http://marc.theaimsgroup.com/?l=linux-kernel&m=111984209416906&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=111966319714417&w=2
http://marc.theaimsgroup.com/?l=linux-kernel&m=111895964717480&w=2
and others.
Thanks,
---
~Randy
Quoted 59 lines · Doug Warzecha
This patch adds the Dell Systems Management Base driver.
The Dell Systems Management Base driver is a character driver that implements ioctls for Dell systems management software to use to communicate with the driver. The driver provides support for Dell systems management software to manage the following Dell PowerEdge
systems: 300, 1300, 1400, 400SC, 500SC, 1500SC, 1550, 600SC, 1600SC, 650, 1655MC, 700, and 750.By making a contribution to this project, I certify that:
The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file.Signed-off-by Doug Warzecha <[email protected]>---
diff -uprN
linux-2.6.13-rc1.orig/drivers/char/dcdbas.clinux-2.6.13-rc1/drivers/char/dcdbas.cdrivers/char/dcdbas.c +38
-0@@ -0,0 +1,777 @@ +/* +* dcdbas.c: Dell Systems Management Base Driver +* +* Copyright (C) 1995-2005 Dell Inc. +* +* The Dell Systems Management Base driver is a character driver that +* implements ioctls for Dell systems management software to use to +* communicate with the driver. The driver provides support for Dell +* systems management software to manage the following Dell PowerEdge +* systems: 300, 1300, 1400, 400SC, 500SC, 1500SC, 1550, 600SC, 1600SC, +* 650, 1655MC, 700, and 750. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License v2.0 as published by +* the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/ + +#include <linux/device.h> +#include <linux/dma-mapping.h> +#include <linux/errno.h> +#include <linux/fs.h> +#include <linux/init.h> +#include <linux/ioctl.h> +#include <linux/kernel.h> +#include <linux/mc146818rtc.h> +#include <linux/module.h> +#include <linux/reboot.h> +#include <linux/sched.h> +#include <linux/slab.h> +#include <linux/smp.h> +#include <linux/string.h> +#include <linux/types.h> +#include <asm/io.h>
drivers/char/dcdbas.c line 48
Quoted 10 lines
drivers/char/dcdbas.c +10
-0+#include <asm/semaphore.h> +#include <asm/uaccess.h> + +#include "dcdbas.h" + +#define DRIVER_NAME "dcdbas" +#define DRIVER_VERSION "5.6.0-1" +#define DRIVER_DESCRIPTION "Systems Management Base Driver" + +static int driver_major;
Why do you need a whole major for this driver? You have more than one device in the system at a time?
drivers/char/dcdbas.c line 61
Quoted 4 lines
drivers/char/dcdbas.c +4
-0+/** +* dcdbas_device_release - device release method +* @dev: device +*/
Don't document functions that do nothing, that's just busy work...
drivers/char/dcdbas.c line 65
Quoted 4 lines
drivers/char/dcdbas.c +4
-0+static void dcdbas_device_release (struct device *dev) +{ +/* nothing to release */ +}
This is a symptom of a broken driver.
Hm, I wonder if there's some way for the compiler to check the fact that a function pointer passed to another function, is really a null function. That would stop this kind of nonsense...
I'm sure I commented on this driver already, yet, I never got a response and the code is not changed. Is there some reason for this? That's a sure way to prevent your patch from ever being applied...
greg k-h
Quoted 10 lines · Greg KH
drivers/char/dcdbas.c line 65
Quoted 4 lines
drivers/char/dcdbas.c +4
-0+static void dcdbas_device_release (struct device *dev) +{ +/* nothing to release */ +}This is a symptom of a broken driver.
Hm, I wonder if there's some way for the compiler to check the fact that a function pointer passed to another function, is really a null function. That would stop this kind of nonsense...
There are other drivers in the kernel tree with null device release functions.
Quoted 4 lines
I'm sure I commented on this driver already, yet, I never got a response and the code is not changed. Is there some reason for this? That's a sure way to prevent your patch from ever being applied...
This is the first comment on the release function. The code has been changing in response to comments from you and others. We'll continue to make changes as needed.
Doug
Quoted 6 lines · Doug Warzecha
Quoted 5 lines · Greg KH
Quoted 4 lines
drivers/char/dcdbas.c +4
-0+static void dcdbas_device_release (struct device *dev) +{ +/* nothing to release */ +}
Quoted 7 lines
Quoted 5 lines
This is a symptom of a broken driver.
Hm, I wonder if there's some way for the compiler to check the fact that a function pointer passed to another function, is really a null function. That would stop this kind of nonsense...
There are other drivers in the kernel tree with null device release functions.
Where?
Quoted 8 lines
Quoted 4 lines
I'm sure I commented on this driver already, yet, I never got a response and the code is not changed. Is there some reason for this? That's a sure way to prevent your patch from ever being applied...
This is the first comment on the release function. The code has been changing in response to comments from you and others. We'll continue to make changes as needed.
You never responded to those questions though, so determining if the code was changed is difficult. And I still see you using ioctls, which, if I remember, was what I asked about.
thanks,
greg k-h
Quoted 9 lines · Greg KH
Quoted 8 lines · Doug Warzecha
Quoted 7 lines · Greg KH
drivers/char/dcdbas.c line 65
Quoted 4 lines
drivers/char/dcdbas.c +4
-0+static void dcdbas_device_release (struct device *dev) +{ +/* nothing to release */ +}This is a symptom of a broken driver.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Hm, I wonder if there's some way for the compiler to check the fact that a function pointer passed to another function, is really a null function. That would stop this kind of nonsense...
There are other drivers in the kernel tree with null device release functions.
Where?
Here's a couple:
drivers/video/vfb.c: vfb_platform_release drivers/video/epson1355fb.c: epson1355fb_platform_release
Doug
Quoted 14 lines · Doug Warzecha
Quoted 13 lines · Greg KH
Quoted 12 lines · Doug Warzecha
Quoted 10 lines · Greg KH
drivers/char/dcdbas.c line 65
Quoted 4 lines
drivers/char/dcdbas.c +4
-0+static void dcdbas_device_release (struct device *dev) +{ +/* nothing to release */ +}This is a symptom of a broken driver.
Hm, I wonder if there's some way for the compiler to check the fact that a function pointer passed to another function, is really a null function. That would stop this kind of nonsense...
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
There are other drivers in the kernel tree with null device release functions.
Where?
Here's a couple:
drivers/video/vfb.c:vfb_platform_releasedrivers/video/epson1355fb.c:epson1355fb_platform_release
Platform devices are a pain. That being said, these are wrong and should be fixed up to use platform_device_register_simple() instead.
It still doesn't justify you doing it in your driver :)
Thanks for pointing it out to me,
greg k-h
Quoted 9 lines · Greg KH
Quoted 3 lines · Doug Warzecha
Quoted 2 lines · Greg KH
I'm sure I commented on this driver already, yet, I never got a
response
Quoted 1 line
Quoted 1 line
and the code is not changed. Is there some reason for this?
That's a
Quoted 2 lines
Quoted 1 line
sure way to prevent your patch from ever being applied...
Quoted 8 lines
Quoted 3 lines
This is the first comment on the release function. The code has been changing in response to comments from you and others. We'll continue to make changes as needed.
You never responded to those questions though, so determining if the code was changed is difficult. And I still see you using ioctls, which, if I remember, was what I asked about.
The dcdbas driver has been shipping outside of the kernel tree for some time now in support of the systems listed in the source and is expected to support the listed systems for some time to come. The driver has always used ioctls for Dell systems management software to communicate with it. The systems that are supported by the driver are older Dell PowerEdge systems which contain Dell proprietary hardware systems management interfaces. The latest shipping PowerEdge systems support the standard IPMI hardware systems management interface which can be accessed by the in-kernel standard IPMI driver (which uses ioctls). Future PowerEdge systems are expected to support the IPMI systems management interface as well.
Even though the dcdbas driver is not expected to be needed for future PowerEdge systems, we would like to make it easier for Dell customers to run Dell systems management software with the latest kernel on the systems supported by the dcdbas driver by making the driver available in the kernel tree. We would like to do that without impacting the existing Dell systems management software for the older systems so that we can focus our resources on the newer systems.
Is it an absolute "must" that this driver not use ioctls?
Doug
Quoted 19 lines · Doug Warzecha
Quoted 9 lines · Greg KH
Quoted 3 lines · Doug Warzecha
Quoted 2 lines · Greg KH
I'm sure I commented on this driver already, yet, I never got a
response
Quoted 1 line
Quoted 1 line
and the code is not changed. Is there some reason for this?
That's a
Quoted 2 lines
Quoted 1 line
sure way to prevent your patch from ever being applied...
Quoted 8 lines
Quoted 3 lines
This is the first comment on the release function. The code has been changing in response to comments from you and others. We'll continue to make changes as needed.
You never responded to those questions though, so determining if the code was changed is difficult. And I still see you using ioctls, which, if I remember, was what I asked about.
Quoted 5 lines
The dcdbas driver has been shipping outside of the kernel tree for some time now in support of the systems listed in the source and is expected to support the listed systems for some time to come. The driver has always used ioctls for Dell systems management software to communicate with it.
Well, your code has always been wrong then :)
Quoted 7 lines
The systems that are supported by the driver are
older Dell PowerEdge systems which contain Dell proprietary hardware systems management interfaces. The latest shipping PowerEdge systems support the standard IPMI hardware systems management interface which can be accessed by the in-kernel standard IPMI driver (which uses ioctls). Future PowerEdge systems are expected to support the IPMI systems management interface as well.
Then only support the "new" interface for newer systems.
Quoted 9 lines
Even though the dcdbas driver is not expected to be needed for future PowerEdge systems, we would like to make it easier for Dell customers to run Dell systems management software with the latest kernel on the systems supported by the dcdbas driver by making the driver available in the kernel tree. We would like to do that without impacting the existing Dell systems management software for the older systems so that we can focus our resources on the newer systems.
Is it an absolute "must" that this driver not use ioctls?
Yes. Sorry.
thanks,
greg k-h