Skip to contentSkip to conversation

rocket.c: Fix ldisc ref count handling

PATCH New Michal Ostrowski 1 participant 1 message Jul 14, 2005 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rocket.c: Fix ldisc ref count handling

If bailing out because there is nothing to receive in rp_do_receive(), tty_ldisc_deref is not called. Failure to do so increases the ref count and causes release_dev() to hang since it can't get the ref count to 0.

---

 drivers/char/rocket.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/char/rocket.c +2 -1
@@ -355,7 +355,7 @@ static void rp_do_receive(struct r_port 
 		ToRecv = space;
 
 	if (ToRecv <= 0)
-		return;
+		goto done;
 
 	/*
 	 * if status indicates there are errored characters in the
@@ -437,6 +437,7 @@ static void rp_do_receive(struct r_port 
 	}
 	/*  Push the data up to the tty layer */
 	ld->receive_buf(tty, tty->flip.char_buf, tty->flip.flag_buf, count);
+ done:
 	tty_ldisc_deref(ld);
 }