Skip to contentSkip to conversation

Fix the recent C-state with FADT regression

PATCH In review Venkatesh Pallipadi 2 participants 2 messages Jul 14, 2005 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix the recent C-state with FADT regression

Attached patch fixes the recent C-state based on FADT regression reported by Kevin.

Please apply.

Thanks,
Venki

Fix the regression with c1_default_handler on some systems where C-states come from FADT.

Thanks to Kevin Radloff for identifying the issue and also root causing on exact line of code that is causing the issue.

/drivers/acpi/processor_idle.c renamed from /drivers/acpi/processor_idle.c.org +1 -1
diff -purN  linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c.org linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c
@@ -881,7 +881,7 @@ static int acpi_processor_get_power_info
 	result = acpi_processor_get_power_info_cst(pr);
 	if ((result) || (acpi_processor_power_verify(pr) < 2)) {
 		result = acpi_processor_get_power_info_fadt(pr);
-		if (result)
+		if ((result) || (acpi_processor_power_verify(pr) < 2))
 			result = acpi_processor_get_power_info_default_c1(pr);
 	}
 
#1 lore raw
Quoted 24 lines · Venkatesh Pallipadi

Attached patch fixes the recent C-state based on FADT regression reported by Kevin.

Please apply.

Thanks,
Venki

Fix the regression with c1_default_handler on some systems where C-states come from FADT.

Thanks to Kevin Radloff for identifying the issue and also root causing on exact line of code that is causing the issue.

diff -purN linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c.org linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c

/drivers/acpi/processor_idle.c static int acpi_processor_get_power_info · line 887

Quoted 8 lines
/drivers/acpi/processor_idle.c renamed from /drivers/acpi/processor_idle.c.org +1 -1
@@ -881,7 +881,7 @@ static int acpi_processor_get_power_info
 	result = acpi_processor_get_power_info_cst(pr);
 	if ((result) || (acpi_processor_power_verify(pr) < 2)) {
 		result = acpi_processor_get_power_info_fadt(pr);
-		if (result)
+		if ((result) || (acpi_processor_power_verify(pr) < 2))
 			result = acpi_processor_get_power_info_default_c1(pr);
 	}
 

It turns out I've had this in my tree since July 6 (from Jindrich Makovicka), sent to Len on July 9. Maybe he's merged it somewhere already.

I have seven acpi patches here, some of which have been in -mm for a very long time. I'll resend them all. Could someone please promptly ack them for 2.6.13 or merge them somewhere or nack the things?

Thanks.