Skip to contentSkip to conversation

block/cpqarray: Audit return code of create_proc_*

PATCH New [email protected] 1 participant 1 message Jul 14, 2005 Block layer

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/2 block/cpqarray: Audit return code of create_proc_*

From: Christophe Lucas <[email protected]>

Audit return of create_proc_* functions.

Signed-off-by Christophe Lucas <[email protected]>
Signed-off-by Domen Puncer <[email protected]>
---
 cpqarray.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletion(-)
drivers/block/cpqarray.c +6 -1
Index: quilt/drivers/block/cpqarray.c
===================================================================
@@ -212,13 +212,18 @@ static struct proc_dir_entry *proc_array
  */
 static void __init ida_procinit(int i)
 {
+	struct proc_dir_entry *ent;
+
 	if (proc_array == NULL) {
 		proc_array = proc_mkdir("cpqarray", proc_root_driver);
 		if (!proc_array) return;
 	}
 
-	create_proc_read_entry(hba[i]->devname, 0, proc_array,
+	ent = create_proc_read_entry(hba[i]->devname, 0, proc_array,
 			       ida_proc_get_info, hba[i]);
+	if (!ent)
+		printk(KERN_WARNING 
+			"cpqarray: Unable to create /proc entry.\n");
 }
 
 /*

--