drivers/ide/ide-tape.c : Use of time_after macro

PATCH New [email protected] 1 participant 1 message Jul 14, 2005 libata

lore

Share & tools

lore

[email protected]

author

2005-07-14 22:21 UTC #0 lore raw

PATCH 1/1 drivers/ide/ide-tape.c : Use of time_after macro

From: Marcelo Feitoza Parisi <[email protected]>

Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read.

Signed-off-by Marcelo Feitoza Parisi <[email protected]>

Signed-off-by Domen Puncer <[email protected]>

---
 ide-tape.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

drivers/ide/ide-tape.c +2 -1

Index: quilt/drivers/ide/ide-tape.c
===================================================================
@@ -443,6 +443,7 @@
 #include <linux/smp_lock.h>
 #include <linux/completion.h>
 #include <linux/bitops.h>
+#include <linux/jiffies.h>
 
 #include <asm/byteorder.h>
 #include <asm/irq.h>

@@ -2333,7 +2334,7 @@ static ide_startstop_t idetape_rw_callba
 	}
 	if (time_after(jiffies, tape->insert_time))
 		tape->insert_speed = tape->insert_size / 1024 * HZ / (jiffies - tape->insert_time);
-	if (jiffies - tape->avg_time >= HZ) {
+	if (time_after_eq(jiffies, tape->avg_time + HZ)) {
 		tape->avg_speed = tape->avg_size * HZ / (jiffies - tape->avg_time) / 1024;
 		tape->avg_size = 0;
 		tape->avg_time = jiffies;