Skip to contentSkip to conversation

fs/smbfs/request.c: turn NULL dereference into BUG()

PATCH New Adrian Bunk 1 participant 1 message Jul 15, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/smbfs/request.c: turn NULL dereference into BUG()

In a case documented as

We should never be called with any of these states

BUG() in a case that would later result in a NULL pointer dereference.

---

This patch was already sent on:
- 26 Mar 2005

fs/smbfs/request.c renamed from fs/smbfs/request.c.old +1 -2
@@ -786,8 +642,7 @@ int smb_request_recv(struct smb_sb_info 
 		/* We should never be called with any of these states */
 	case SMB_RECV_END:
 	case SMB_RECV_REQUEST:
-		server->rstate = SMB_RECV_END;
-		break;
+		BUG();
 	}
 
 	if (result < 0) {