Skip to contentSkip to conversation

drivers/media/video/tveeprom.c: possible cleanups

PATCH In review Adrian Bunk 2 participants 2 messages Jul 15, 2005 Media (V4L/DVB)

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 drivers/media/video/tveeprom.c: possible cleanups

This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump

Signed-off-by Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 9 Jul 2005
- 19 Apr 2005

 drivers/media/video/tveeprom.c |    6 ++++--
 include/media/tveeprom.h       |    1 -
 2 files changed, 4 insertions(+), 3 deletions(-)
include/media/tveeprom.h renamed from include/media/tveeprom.h.old +0 -1
@@ -20,4 +20,3 @@
 			       unsigned char *eeprom_data);
 
 int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len);
-int tveeprom_dump(unsigned char *eedata, int len);
drivers/media/video/tveeprom.c renamed from drivers/media/video/tveeprom.c.old +4 -2
@@ -453,6 +453,7 @@
 }
 EXPORT_SYMBOL(tveeprom_read);
 
+#if 0
 int tveeprom_dump(unsigned char *eedata, int len)
 {
 	int i;

@@ -468,6 +469,7 @@
 	return 0;
 }
 EXPORT_SYMBOL(tveeprom_dump);
+#endif  /*  0  */
 
 /* ----------------------------------------------------------------------- */
 /* needed for ivtv.sf.net at the moment.  Should go away in the long       */

@@ -484,7 +486,7 @@
 };
 I2C_CLIENT_INSMOD;
 
-struct i2c_driver i2c_driver_tveeprom;
+static struct i2c_driver i2c_driver_tveeprom;
 
 static int
 tveeprom_command(struct i2c_client *client,

@@ -556,7 +558,7 @@
 	return 0;
 }
 
-struct i2c_driver i2c_driver_tveeprom = {
+static struct i2c_driver i2c_driver_tveeprom = {
 	.owner          = THIS_MODULE,
 	.name           = "tveeprom",
 	.id             = I2C_DRIVERID_TVEEPROM,
#1 lore raw

Adrian,

Your patch is at my personal TODO list.

We had lots of patches for 2.6.13, with some sigificative enhancements.

Unfortunatelly, your patch from 19 Apr 2005 was not applied, maybe
because you've sent during a period where V4L was Orphaned.

We've decided to stop non-bug fixes just some days before your newer
attempt (July, 7) to focus on more tests at a stable branch. Until July, 18, V4L are applying only bug fixes. After that, we'll collect more patches at V4L and, maybe at the end of the next week, we'll send the patchsets, including yours (It will be #1 :-) ).

Cheers,

Mauro.

Quoted 12 lines · Adrian Bunk

This patch contains the following possible cleanups:
- make two needlessly global structs static
- #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump

Signed-off-by Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 9 Jul 2005
- 19 Apr 2005