drivers/net/tokenring/3c359.c : Use of the
Subsystems (2)
PATCH 1/1 drivers/net/tokenring/3c359.c : Use of the
Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read.
drivers/net/tokenring/3c359.c +11 -10
@@ -62,6 +62,7 @@#include <linux/pci.h> #include <linux/spinlock.h> #include <linux/bitops.h> +#include <linux/jiffies.h> #include <net/checksum.h>
@@ -410,7 +411,7 @@ t=jiffies;while (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_CMD_IN_PROGRESS ) {schedule (); -if (jiffies-t >40 *HZ ) { +if (time_after (jiffies, t +40 *HZ )) {printk (KERN_ERR "%s: 3COM 3C359 Velocity XL card not responding to global reset.\n" , dev->name);return -ENODEV ; }
@@ -521,7 +522,7 @@ t=jiffies;while ( !(readw (xl_mmio +MMIO_INTSTATUS_AUTO ) &INTSTAT_SRB ) ) {schedule (); -if (jiffies-t >15 *HZ ) { +if (time_after (jiffies, t +15 *HZ )) {printk (KERN_ERR "3COM 3C359 Velocity XL card not responding.\n" );return -ENODEV ; }
@@ -797,7 +798,7 @@ t=jiffies;while (! (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_SRB )) {schedule (); -if (jiffies-t >40 *HZ ) { +if (time_after (jiffies, t +40 *HZ )) {printk (KERN_ERR "3COM 3C359 Velocity XL card not responding.\n" );break ; }
@@ -1012,7 +1013,7 @@ t=jiffies;while (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_CMD_IN_PROGRESS ) { -if (jiffies-t >40 *HZ ) { +if (time_after (jiffies, t +40 *HZ )) {printk (KERN_ERR "3COM 3C359 Velocity XL card not responding.\n" );break ; }
@@ -1284,7 +1285,7 @@ t=jiffies;while (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_CMD_IN_PROGRESS ) {schedule (); -if (jiffies-t >10 *HZ ) { +if (time_after (jiffies, t +10 *HZ )) {printk (KERN_ERR "%s: 3COM 3C359 Velocity XL-DNSTALL not responding.\n" , dev->name);break ; }
@@ -1293,7 +1294,7 @@ t=jiffies;while (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_CMD_IN_PROGRESS ) {schedule (); -if (jiffies-t >10 *HZ ) { +if (time_after (jiffies, t +10 *HZ )) {printk (KERN_ERR "%s: 3COM 3C359 Velocity XL-DNDISABLE not responding.\n" , dev->name);break ; }
@@ -1302,7 +1303,7 @@ t=jiffies;while (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_CMD_IN_PROGRESS ) {schedule (); -if (jiffies-t >10 *HZ ) { +if (time_after (jiffies, t +10 *HZ )) {printk (KERN_ERR "%s: 3COM 3C359 Velocity XL-UPSTALL not responding.\n" , dev->name);break ; }
@@ -1319,7 +1320,7 @@ t=jiffies;while (!(readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_SRB )) {schedule (); -if (jiffies-t >10 *HZ ) { +if (time_after (jiffies, t +10 *HZ )) {printk (KERN_ERR "%s: 3COM 3C359 Velocity XL-CLOSENIC not responding.\n" , dev->name);break ; }
@@ -1348,7 +1349,7 @@ t=jiffies;while (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_CMD_IN_PROGRESS ) {schedule (); -if (jiffies-t >10 *HZ ) { +if (time_after (jiffies, t +10 *HZ )) {printk (KERN_ERR "%s: 3COM 3C359 Velocity XL-UPRESET not responding.\n" , dev->name);break ; }
@@ -1357,7 +1358,7 @@ t=jiffies;while (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_CMD_IN_PROGRESS ) {schedule (); -if (jiffies-t >10 *HZ ) { +if (time_after (jiffies, t +10 *HZ )) {printk (KERN_ERR "%s: 3COM 3C359 Velocity XL-DNRESET not responding.\n" , dev->name);break ; }
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 18 lines · Marcelo Feitoza Parisi
Use of the
time_after()macro, defined atlinux/jiffies.h, which deal with wrapping correctly and are nicer to read.Signed-off-by Marcelo Feitoza Parisi <[email protected]>drivers/net/tokenring/3c359.c +1
-0@@ -62,6 +62,7 @@#include <linux/pci.h> #include <linux/spinlock.h> #include <linux/bitops.h> +#include <linux/jiffies.h> #include <net/checksum.h>
drivers/net/tokenring/3c359.c line 417
Quoted 8 lines
drivers/net/tokenring/3c359.c +1
-1@@ -410,7 +411,7 @@ t=jiffies;while (readw (xl_mmio +MMIO_INTSTATUS ) &INTSTAT_CMD_IN_PROGRESS ) {schedule (); -if (jiffies-t >40 *HZ ) { +if (time_after (jiffies, t +40 *HZ )) {printk (KERN_ERR "%s: 3COM 3C359 Velocity XL card not responding to global reset.\n" , dev->name);return -ENODEV ; }
There are 7 of these, almost exactly the same.
Maybe a nice wrapper?
drivers/net/tokenring/3c359.c line 524
Quoted 4 lines
drivers/net/tokenring/3c359.c +0
-0@@ -521,7 +522,7 @@ t=jiffies;while ( !(readw (xl_mmio +MMIO_INTSTATUS_AUTO ) &INTSTAT_SRB ) ) {schedule ();
This looks at least a bit weird. No set_current_state()? And if it were, would it ever return?
drivers/net/tokenring/3c359.c line 525
Quoted 2 lines
drivers/net/tokenring/3c359.c +1
-1-if (jiffies-t >15 *HZ ) { +if (time_after (jiffies, t +15 *HZ )) {
^ space missing
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors