Skip to contentSkip to conversation

QLA2xxx FW_LOADER Kconfig issue results in undefined symbols

PATCH In review Erik Jacobson 2 participants 2 messages Jul 18, 2005 – Jul 19, 2005

Subsystems (2)
SCSI QLogic QLA2XXX FC-SCSI driver
lore
Share & tools
lore

Erik Jacobson

author
#0 lore raw

PATCH 1/1 QLA2xxx FW_LOADER Kconfig issue results in undefined symbols

I hit a small problem (first observed in 2.6.13-rc3-mm1) that resulted in my kernels no longer building because of undefined references to request_firmware and release_firmware.

After a little research, I found that the QLA stuff requires CONFIG_FW_LOADER.

I was using the sn2_defconfig as a starting point for my config file. This config file compiles some of the QLA2xxx drivers statically. By default, CONFIG_FW_LOADER is set to "m" and not "y".

So this small change should ensure CONFIG_FW_LOADER is set properly.

Perhaps there are better ways to do this?

Signed-off-by Erik Jacobson <[email protected]>

---

 Kconfig |    1 +
 1 files changed, 1 insertion(+)
drivers/scsi/qla2xxx/Kconfig +1 -0
diff -Naru 2.6-akpm-rc-mm-orig/drivers/scsi/qla2xxx/Kconfig 2.6-akpm-rc-mm/drivers/scsi/qla2xxx/Kconfig
@@ -3,6 +3,7 @@
 	default (SCSI && PCI)
 	depends on SCSI && PCI
 	select SCSI_FC_ATTRS
+	select FW_LOADER
 
 config SCSI_QLA21XX
 	tristate "QLogic ISP2100 host adapter family support"

--
Erik Jacobson - Linux System Software - Silicon Graphics - Eagan, Minnesota

#1 lore raw
Quoted 17 lines · Erik Jacobson

I hit a small problem (first observed in 2.6.13-rc3-mm1) that resulted in my kernels no longer building because of undefined references to request_firmware and release_firmware.

After a little research, I found that the QLA stuff requires CONFIG_FW_LOADER.

I was using the sn2_defconfig as a starting point for my config file. This config file compiles some of the QLA2xxx drivers statically. By default, CONFIG_FW_LOADER is set to "m" and not "y".

So this small change should ensure CONFIG_FW_LOADER is set properly.

Perhaps there are better ways to do this?
...

drivers/scsi/qla2xxx/Kconfig line 9

Quoted 8 lines
drivers/scsi/qla2xxx/Kconfig +1 -0
@@ -3,6 +3,7 @@
 	default (SCSI && PCI)
 	depends on SCSI && PCI
 	select SCSI_FC_ATTRS
+	select FW_LOADER
 
 config SCSI_QLA21XX
 	tristate "QLogic ISP2100 host adapter family support"
...

I have to resend my patch for this issue that didn't make it through the linux-kernel filters.

Your patch enables FW_LOADER for everyone with (SCSI && PCI) since is a not user-visible option that is enabled then.

The correct solution my patch does is to add a "select FW_LOADER" to every single of the driver options below.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed