Skip to contentSkip to conversation

VIA_VELOCITY must depend on INET

PATCH In review Adrian Bunk 2 participants 2 messages Jul 19, 2005 – Jul 20, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 VIA_VELOCITY must depend on INET

VIA_VELOCITY=y and INET=n results in the following compile error:

<-- snip -->

...
LD .tmp_vmlinux1
drivers/built-in.o: In function `velocity_register_notifier':
via-velocity.c:(.text+0x3462c6): undefined reference to register_inetaddr_notifier' drivers/built-in.o: In function velocity_unregister_notifier':
via-velocity.c:(.text+0x3462d6): undefined reference to `unregister_inetaddr_notifier'
make: *** [.tmp_vmlinux1] Error 1

<-- snip -->

drivers/net/Kconfig renamed from drivers/net/Kconfig.old +1 -1
@@ -2016,7 +2016,7 @@
 
 config VIA_VELOCITY
 	tristate "VIA Velocity support"
-	depends on NET_PCI && PCI
+	depends on INET && NET_PCI && PCI
 	select CRC32
 	select CRC_CCITT
 	select MII
#1 lore raw
Quoted 11 lines · Adrian Bunk

VIA_VELOCITY=y and INET=n results in the following compile error:

<-- snip -->

...
LD .tmp_vmlinux1
drivers/built-in.o: In function `velocity_register_notifier':
via-velocity.c:(.text+0x3462c6): undefined reference to register_inetaddr_notifier' drivers/built-in.o: In function velocity_unregister_notifier':
via-velocity.c:(.text+0x3462d6): undefined reference to `unregister_inetaddr_notifier'
make: *** [.tmp_vmlinux1] Error 1

Alternatively you could drop those functions when CONFIG_INET is n as they are only used for wake on arp