Skip to contentSkip to conversation

drivers/ieee1394/sbp2.c: fix warnings with -Wundef

PATCH In review Adrian Bunk 2 participants 2 messages Jul 22, 2005 – Jul 23, 2005

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 drivers/ieee1394/sbp2.c: fix warnings with -Wundef

This patch fixes the following warnings with -Wundef:

<-- snip -->

...
CC drivers/ieee1394/sbp2.o
drivers/ieee1394/sbp2.c:202:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined drivers/ieee1394/sbp2.c:207:7: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined drivers/ieee1394/sbp2.c:2053:6: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined drivers/ieee1394/sbp2.c:2623:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined
...

<-- snip -->

Signed-off-by Adrian Bunk <[email protected]>
drivers/ieee1394/sbp2.c renamed from drivers/ieee1394/sbp2.c.old +3 -2
@@ -171,10 +171,11 @@
 
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
 /* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
 
+/* CONFIG_IEEE1394_SBP2_DEBUG: 0-2 */
+#define CONFIG_IEEE1394_SBP2_DEBUG 0
+
 #ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
 #define SBP2_ORB_DEBUG(fmt, args...)	HPSB_ERR("sbp2(%s): "fmt, __FUNCTION__, ## args)
 static u32 global_outstanding_command_orbs = 0;
#1 lore raw
Quoted 4 lines · Adrian Bunk

drivers/ieee1394/sbp2.c:202:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined drivers/ieee1394/sbp2.c:207:7: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined drivers/ieee1394/sbp2.c:2053:6: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined drivers/ieee1394/sbp2.c:2623:5: warning: "CONFIG_IEEE1394_SBP2_DEBUG" is not defined

Here is a minimally improved version of the patch. I kept your sign-off.

- - - - - - - - - - - - 8< - - - - - - - - - - - -

sbp2: fix compiler warnings with -Wundef

Signed-off-by Adrian Bunk <[email protected]>
Signed-off-by Stefan Richter <[email protected]>
drivers/ieee1394/sbp2.c +4 -2
Index: linux-2.6.13-rc3/drivers/ieee1394/sbp2.c
===================================================================
@@ -171,10 +171,12 @@
 
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_ORBS */
 /* #define CONFIG_IEEE1394_SBP2_DEBUG_DMA */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 1 */
-/* #define CONFIG_IEEE1394_SBP2_DEBUG 2 */
 /* #define CONFIG_IEEE1394_SBP2_PACKET_DUMP */
 
+/* increase to 1 for verbose logging, to 2 for even more logging */
+#define CONFIG_IEEE1394_SBP2_DEBUG 0
+
+
 #ifdef CONFIG_IEEE1394_SBP2_DEBUG_ORBS
 #define SBP2_ORB_DEBUG(fmt, args...)	HPSB_ERR("sbp2(%s): "fmt, __FUNCTION__, ## args)
 static u32 global_outstanding_command_orbs = 0;