Skip to contentSkip to conversation

load ave >= 1

PATCH In review Jeff Dike 2 participants 2 messages Jul 27, 2005 User-mode Linux (UML)

lore
Share & tools
lore

Jeff Dike

author
#0 lore raw

PATCH 1/1 load ave >= 1

The patch below might fix the ksoftirqd load average >= 1 problem.

I can't reproduce it, but in chasing it in one of Chris Aker's non-debuggable images, I uncovered this bug.

Testing and feedback are welcome.

It's applied against my incrementals, but it should be easy to apply in any other UML.

Jeff

arch/um/kernel/time_kern.c +2 -0
Index: linux-2.6.12/arch/um/kernel/time_kern.c
===================================================================
@@ -189,8 +189,10 @@
 void timer_handler(int sig, union uml_pt_regs *regs)
 {
 	local_irq_disable();
+	irq_enter();
 	update_process_times(CHOOSE_MODE(user_context(UPT_SP(regs)), 
 					 (regs)->skas.is_user));
+	irq_exit();
 	local_irq_enable();
 	if(current_thread->cpu == 0)
 		timer_irq(regs);

-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

#1 lore raw
Quoted 1 line · Jeff Dike

Testing and feedback are welcome.

Looks good here!

Cpu(s): 0.0% us, 0.0% sy, 0.0% ni, 100.0% id, 0.0% wa, 0.0% hi, 0.0% si

Thanks,
-Chris

-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies from IBM. Find simple to follow Roadmaps, straightforward articles, informative Webcasts and more! Get everything you need to get up to speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel