Skip to contentSkip to conversation

Fix incorrect Asus k7m irq router detection

PATCH In review Giancarlo Formicuccia 2 participants 2 messages Jul 27, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix incorrect Asus k7m irq router detection

Hi,

this patch:
http://marc.theaimsgroup.com/?l=bk-commits-head&m=111955644929114&w=2
uncovered a k7m bios bug, where the VT82C686A router is reported as being "586-compatible". The two chips have different pirq mapping, so this leads to "irq routing conflict" on many pci devices.

The suggested fix was discussed with Aleksey Gorelov, who helped me to identify the problem as a probable bios bug.

Patch for 2.6.13-git4.

arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.org +7 -0
@@ -550,6 +550,13 @@
 static __init int via_router_probe(struct irq_router *r, struct pci_dev *router, u16 device)
 {
 	/* FIXME: We should move some of the quirk fixup stuff here */
+
+	if (router->device == PCI_DEVICE_ID_VIA_82C686 &&
+			device == PCI_DEVICE_ID_VIA_82C586_0) {
+		/* Asus k7m bios wrongly reports 82C686A as 586-compatible */
+		device = PCI_DEVICE_ID_VIA_82C686;
+	}
+
 	switch(device)
 	{
 		case PCI_DEVICE_ID_VIA_82C586_0:
#1 lore raw
Quoted 19 lines · Giancarlo Formicuccia

this patch:
http://marc.theaimsgroup.com/?l=bk-commits-head&m=111955644929114&w=2
uncovered a k7m bios bug, where the VT82C686A router is reported as being "586-compatible". The two chips have different pirq mapping, so this leads to "irq routing conflict" on many pci devices.

The suggested fix was discussed with Aleksey Gorelov, who helped me to identify the problem as a probable bios bug.

Patch for 2.6.13-git4.

arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.org +0 -0
@@ -550,6 +550,13 @@
 static __init int via_router_probe(struct irq_router *r, struct pci_dev *router, u16 device)
 {
 	/* FIXME: We should move some of the quirk fixup stuff here */

arch/i386/pci/irq.c line 562

Quoted 10 lines
arch/i386/pci/irq.c renamed from arch/i386/pci/irq.c.org +7 -0
+
+	if (router->device == PCI_DEVICE_ID_VIA_82C686 &&
+			device == PCI_DEVICE_ID_VIA_82C586_0) {
+		/* Asus k7m bios wrongly reports 82C686A as 586-compatible */
+		device = PCI_DEVICE_ID_VIA_82C686;
+	}
+
 	switch(device)
 	{
 		case PCI_DEVICE_ID_VIA_82C586_0:

If this really is a problem with that board, it should have a DMI entry for that board alone, not for every VIA chipset that uses the 586/686 combo, as I'm fairly certain there are some that legitimately use this combination, and the patch above will force them all to be reported as 82C686's.

Dave