include/net/ieee80211.h must #include <linux/wireless.h>
Subsystems (2)
PATCH 1/1 include/net/ieee80211.h must #include <linux/wireless.h>
gcc found an (although perhaps harmless) bug:
<-- snip -->
...
CC net/ieee80211/ieee80211_crypt.o
In file included from net/ieee80211/ieee80211_crypt.c:21:include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
CC net/ieee80211/ieee80211_crypt_wep.o
In file included from net/ieee80211/ieee80211_crypt_wep.c:20:include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
CC net/ieee80211/ieee80211_crypt_ccmp.o
CC net/ieee80211/ieee80211_crypt_tkip.o
In file included from net/ieee80211/ieee80211_crypt_tkip.c:23:include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined
...
<-- snip -->
---
This patch was already sent on:
- 22 Jul 2005
include/net/ieee80211.h renamed from include/net/ieee80211.h.old +1 -0
@@ -22,6 +22,7 @@#define IEEE80211_H #include <linux/if_ether.h> /* ETH_ALEN */ #include <linux/kernel.h> /* ARRAY_SIZE */ +#include <linux/wireless.h> #if WIRELESS_EXT <17 #define IW_QUAL_QUAL_INVALID 0x10
Quoted 11 lines · Adrian Bunk
gcc found an (although perhaps harmless) bug:
CC
net/ieee80211/ieee80211_crypt.o
In file included fromnet/ieee80211/ieee80211_crypt.c:21:include/net/ieee80211.h:26:5: warning: "WIRELESS_EXT" is not defined+++
linux-2.6.13-rc3-mm1-full/include/net/ieee80211.h2005-07-22 18:38:10.000000000 +0200
+#include <linux/wireless.h>#if
WIRELESS_EXT< 17
#defineIW_QUAL_QUAL_INVALID0x10
Wouldn't the proper fix be to just remove this backwards compatibility code since WIRELESS_EXT is actually 18 in this tree anyway.. Is there valid need to keep this header file compatible with older kernel versions?
Signature · 1 line
Jouni Malinen PGP id EFC895FA
Quoted 4 lines · Jouni Malinen
Wouldn't the proper fix be to just remove this backwards compatibility code since
WIRELESS_EXTis actually 18 in this tree anyway.. Is there valid need to keep this header file compatible with older kernel versions?
Nope. Ripping out such back-compat code would be quite acceptable.
Jeff