Skip to contentSkip to conversation

VIA PCI routing problem

PATCH Nick Piggin 2 participants 3 messages Jul 28, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

Sorry in taking so long to track this down. I just got motivated today.

I have a VIA SMP system and somewhere between 2.6.12-rc3 and 2.6.12 the USB mouse started moving around really slowly. Anyway, it turns out that the attached patch (against 2.6.13-rc3-git8) fixes the problem.

Let me know if any info is needed or if you would like me to test a patch.

This is a regression versus 2.6.11 so it would be good to have a fix in 2.6.13.

Thanks,
Nick

Signature · 1 line
SUSE Labs, Novell Inc.
arch/i386/pci/irq.c +1 -0
Index: linux-2.6/arch/i386/pci/irq.c
===================================================================
@@ -1132,6 +1132,7 @@ static int pirq_enable_irq(struct pci_de
 		printk(KERN_WARNING "PCI: No IRQ known for interrupt pin %c of device %s.%s\n",
 		       'A' + pin, pci_name(dev), msg);
 	}
+	pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq & 15);
 	return 0;
 }
 
drivers/pci/quirks.c +2 -0
Index: linux-2.6/drivers/pci/quirks.c
===================================================================
@@ -499,6 +499,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_V
  */
 static void quirk_via_irq(struct pci_dev *dev)
 {
+#if 0
 	u8 irq, new_irq;
 
 	new_irq = dev->irq & 0xf;
@@ -509,6 +510,7 @@ static void quirk_via_irq(struct pci_dev
 		udelay(15);	/* unknown if delay really needed */
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
+#endif
 }
 DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
 
drivers/acpi/pci_irq.c +2 -0
Index: linux-2.6/drivers/acpi/pci_irq.c
===================================================================
@@ -444,6 +444,8 @@ acpi_pci_irq_enable (
 		}
  	}
 
+	pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq & 15);
+
 	dev->irq = acpi_register_gsi(irq, edge_level, active_high_low);
 
 	printk(KERN_INFO PREFIX "PCI Interrupt %s[%c] -> ",
#1 lore raw
Quoted 3 lines · Nick Piggin

I have a VIA SMP system and somewhere between 2.6.12-rc3 and 2.6.12 the USB mouse started moving around really slowly. Anyway, it turns out that the attached patch (against 2.6.13-rc3-git8) fixes the problem.

Can you try this:

drivers/pci/quirks.c +1 -1
Index: work/drivers/pci/quirks.c
===================================================================
@@ -503,7 +503,7 @@
 
 	new_irq = dev->irq & 0xf;
 	pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
-	if (new_irq != irq) {
+	if (1 || new_irq != irq) {
 		printk(KERN_INFO "PCI: Via IRQ fixup for %s, from %d to %d\n",
 			pci_name(dev), irq, new_irq);
 		udelay(15);	/* unknown if delay really needed */

If that doesn't help, remove it and see if this does:

drivers/pci/quirks.c +1 -1
Index: work/drivers/pci/quirks.c
===================================================================
@@ -510,7 +510,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * PIIX3 USB: We have to disable USB interrupts that are

Can you also include "lspci" output?

#2 lore raw
Quoted 3 lines · Bjorn Helgaas

Can you try this:

[...]

Quoted 4 lines

If that doesn't help, remove it and see if this does:

[...]

Quoted 3 lines

Can you also include "lspci" output?

Neither worked. I'll open a bugzilla and include lspci and dmesg there.

Signature · 3 lines
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com