Skip to contentSkip to conversation

bio_clone fix

PATCH In review Andrew Morton 2 participants 2 messages Jul 28, 2005 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bio_clone fix

This is an important fix affecting both 2.6.11 and 2.6.12. Anyone who is experiencing data loss issues on MD or DM setups with those kernels should apply.

Begin forwarded message:

Date: Thu, 28 Jul 2005 10:31:10 -0700
From: Linux Kernel Mailing List <[email protected]>
To: [email protected]
Subject: [PATCH] bio_clone fix

tree c1d224f0fb4db22e87567e1eea45001a7b11e51f
parent 577a4f8102d54b504cb22eb021b89e957e8df18f
author Andrew Morton <[email protected]> Thu, 28 Jul 2005 15:07:18 -0700 committer Linus Torvalds <[email protected]> Thu, 28 Jul 2005 22:38:59 -0700

[PATCH] bio_clone fix

Fix bug introduced in 2.6.11-rc2: when we clone a BIO we need to copy over the current index into it as well.

It corrupts data with some MD setups.

See http://bugzilla.kernel.org/show_bug.cgi?id=4946

Huuuuuuuuge thanks to Matthew Stapleton <[email protected]> for doggedly chasing this one down.

 fs/bio.c |    1 +
 1 files changed, 1 insertion(+)
fs/bio.c +1 -0
@@ -261,6 +261,7 @@ inline void __bio_clone(struct bio *bio,
 	 */
 	bio->bi_vcnt = bio_src->bi_vcnt;
 	bio->bi_size = bio_src->bi_size;
+	bio->bi_idx = bio_src->bi_idx;
 	bio_phys_segments(q, bio);
 	bio_hw_segments(q, bio);
 }

-
To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw
Quoted 4 lines · * Andrew Morton ([email protected]) wrote:

This is an important fix affecting both 2.6.11 and 2.6.12. Anyone who is experiencing data loss issues on MD or DM setups with those kernels should apply.

Thanks, queued to -stable.
-chris