Skip to contentSkip to conversation

2.6.13 ub 2/3: Fold one line

PATCH Pete Zaitcev 5 participants 5 messages Jul 31, 2005 Block layer

lore
Share & tools
lore
#0 lore raw

Evidently, Yani Ioannou's display is wider than mine.

drivers/block/ub.c +2 -1
@@ -516,7 +516,8 @@ static void ub_cmdtr_sense(struct ub_dev
 	}
 }
 
-static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr, char *page)
+static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr,
+    char *page)
 {
 	struct usb_interface *intf;
 	struct ub_dev *sc;
#1 lore raw

From: Pete Zaitcev <[email protected]>
Date: Sat, 30 Jul 2005 22:51:45 -0700

drivers/block/ub.c static void ub_cmdtr_sense(struct ub_dev · line 520

Quoted 3 lines
drivers/block/ub.c +2 -1
-static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr, char *page)
+static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr,
+    char *page)

FWIW, I am generally against this kind of thing at least for non-static functions.

I used to love this kind of code styling, until I started trying to often grep a tree to verify the types of arguments to some function.

With the above kind of construct, you get the first few types, but not all of them, in your grep output.

#2 lore raw
Quoted 12 lines · David S. Miller

From: Pete Zaitcev <[email protected]>
Date: Sat, 30 Jul 2005 22:51:45 -0700

drivers/block/ub.c static void ub_cmdtr_sense(struct ub_dev · line 520

Quoted 3 lines
drivers/block/ub.c +2 -1
-static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr, char *page)
+static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr,
+    char *page)

FWIW, I am generally against this kind of thing at least for non-static functions.

Quoted 5 lines

I used to love this kind of code styling, until I started trying to often grep a tree to verify the types of arguments to some function.

With the above kind of construct, you get the first few types, but not all of them, in your grep output.

A better solution would be to stop naming_structures_as_complete_sentences.

IMO there's a happy balance between BSD's squash-everything-into-6-chars style and recent kernel code's tendency to bypass the ancient C 32-char limit.

But ah well ;-)

Jeff

#3 lore raw
In reply to Pete Zaitcev
Quoted 1 line · Pete Zaitcev

Evidently, Yani Ioannou's display is wider than mine.

1600x1200@15" (Thinkpad) ;-). The changes were done by a script I wrote which wasn't checking if the 80 chars limit was surpassed.

Yani

#4 lore raw
Quoted 5 lines · Yani Ioannou
Quoted 1 line · Pete Zaitcev

Evidently, Yani Ioannou's display is wider than mine.

1600x1200@15" (Thinkpad) ;-). The changes were done by a script I wrote which wasn't checking if the 80 chars limit was surpassed.

And repairing the files you stomped on? A combination of you stomping coding style plus a maintainer insisting on trailing whitespace was enough for me to give up working in that area.

Grant.