Skip to contentSkip to conversation

latency logger for realtime-preempt-2.6.12-final-V0.7.51-30

PATCH Yang Yi 3 participants 4 messages Aug 3, 2005 – Aug 11, 2005

lore
Share & tools
lore

Yang Yi

author
#0 lore raw
Quoted 9 lines
Quoted 5 lines

Hi, Ingo

This patch can record interrupt-off latency, preemption-off latency and wakeup latency in a big history array, in the meanwhile, it dummies up printks produced by these latency timing.

looks pretty good! I'll look at merging your patch after KS/OLS.

Ingo

Hi, ingo

Do you have any trouble while you merge that latency logger patch?

#1 lore raw
Quoted 3 lines · Yang Yi
Quoted 1 line

looks pretty good! I'll look at merging your patch after KS/OLS.

Do you have any trouble while you merge that latency logger patch?

i've merged it to the -52-11 patch that, and i've uploaded it a couple of minutes ago.

i have done a number of cleanups on it - e.g. instead of latency logging it's now called latency histogram, and i've also fixed a number of coding style issues. Please double-check that it's still OK, seems to work here.

would be nice to clean up the impact of the latency-histogram code some more though: e.g. the #ifdef jungle check_critical_timing() is disgusting. Could be cleaned up by always recording the latency_type being currently traced into a new tr->latency_type field, and then using that in check_critical_timing().

Ingo

#2 lore raw
Quoted 5 lines · Ingo Molnar

would be nice to clean up the impact of the latency-histogram code some more though: e.g. the #ifdef jungle check_critical_timing() is disgusting. Could be cleaned up by always recording the latency_type being currently traced into a new tr->latency_type field, and then using that in check_critical_timing().

the code appears to be adding ifdefs to make preempt_max_latency work like preempt_threshold , I think all the nasty ifdefs could go away if we just made it use preempt_threshold .. Plus it logs latency during boot up cause preempt_max_latency equals zero .

Daniel

#3 lore raw
Quoted 8 lines · Daniel Walker
Quoted 5 lines · Ingo Molnar

would be nice to clean up the impact of the latency-histogram code some more though: e.g. the #ifdef jungle check_critical_timing() is disgusting. Could be cleaned up by always recording the latency_type being currently traced into a new tr->latency_type field, and then using that in check_critical_timing().

Quoted 4 lines

the code appears to be adding ifdefs to make preempt_max_latency work like preempt_threshold , I think all the nasty ifdefs could go away if we just made it use preempt_threshold .. Plus it logs latency during boot up cause preempt_max_latency equals zero .

yes. Would be nice to have these cleanups too. The #ifdef impact of the LATENCY_HIST code is quite high at the moment, and it needs to be decreased.

Ingo