drivers/char/isicom.c old api rewritten
PATCH 1/1 drivers/char/isicom.c old api rewritten
Hello.
Could you send me critics and bugs?
Could somebody test it (but NOT now)?
Thanks.
drivers/char/isicom.c | 1610 ++++++++++++++++++++++++-------------------------include/linux/isicom.h | 8
2 files changed, 817 insertions(+), 801 deletions(-)
Here it is (about 65 KiB):
http://www.fi.muni.cz/~xslaby/lnx/isi.txt
Signature · 3 lines
Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [email protected] ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10
Jiri Slaby napsal(a):
Quoted 1 line
Could somebody test it (but NOT now)?
Ok, could anybody test it now, if no problems were discovered, please?
Quoted 2 lines · Jiri Slaby
Hello.
Could you send me critics and bugs?
You have much bigger chances of someone reviewing the patch if you at least split code changes and whitespace/type cleanups. 65k is a lot.
Quoted 9 lines
Could somebody test it (but NOT now)?
Thanks.
drivers/char/isicom.c| 1610
++++++++++++++++++++++++-------------------------include/linux/isicom.h| 82 files changed, 817 insertions(+), 801 deletions(-)Here it is (about 65 KiB):
It should deserve a few bytes of description ;-)
Quoted 2 lines
Domen Puncer napsal(a):
Quoted 4 lines
You have much bigger chances of someone reviewing the patch if you at least split code changes and whitespace/type cleanups. 65k is a lot.
Ok, 3 patches:
http://www.fi.muni.cz/~xslaby/lnx/isi_main.txt
this changes many lines of code, adds hotplug, firmware loading, add one fixme, because i have really no idea, what device feed to request_firmware when isa card is used
http://www.fi.muni.cz/~xslaby/lnx/isi_us.txt
unsigned short changed to u16 and similar, where it expect sized operands
http://www.fi.muni.cz/~xslaby/lnx/isi_w.txt
changes trying to convert code into CodingStyle removed trailing spaces, some lines longer than 80 split
Signature · 3 lines
Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [email protected] ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10