Skip to contentSkip to conversation

add MODULE_ALIAS for x86_64 aes

PATCH In review Olaf Hering 5 participants 7 messages Aug 8, 2005 – Aug 11, 2005 Crypto API

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 add MODULE_ALIAS for x86_64 aes

modprobe aes does not work on x86_64. i386 has a similar line, this could be the right fix. Would be nice to have in 2.6.13 final.

Signed-off-by Olaf Hering <[email protected]>
 arch/x86_64/crypto/aes.c |    1 +
 1 files changed, 1 insertion(+)
arch/x86_64/crypto/aes.c +1 -0
Index: linux-2.6.13-rc6-aes/arch/x86_64/crypto/aes.c
===================================================================
@@ -322,3 +322,4 @@ module_exit(aes_fini);
 
 MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("aes");
#1 lore raw
Quoted 5 lines · Olaf Hering

modprobe aes does not work on x86_64. i386 has a similar line, this could be the right fix. Would be nice to have in 2.6.13 final.

What do you mean by "this could be the right fix"? Did it work?

Quoted 10 lines

Index: linux-2.6.13-rc6-aes/arch/x86_64/crypto/aes.c
===================================================================

arch/x86_64/crypto/aes.c +1 -0
@@ -322,3 +322,4 @@ module_exit(aes_fini);
 
 MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("aes");
author
#2 lore raw
Quoted 8 lines · Andrew Morton
Quoted 5 lines · Olaf Hering

modprobe aes does not work on x86_64. i386 has a similar line, this could be the right fix. Would be nice to have in 2.6.13 final.

What do you mean by "this could be the right fix"? Did it work?

I cant test it due to lack of hardware. Will find someone who does. modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.

author
#3 lore raw
Quoted 5 lines · Olaf Hering
Quoted 3 lines · Andrew Morton
Quoted 2 lines · Olaf Hering
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

modprobe aes does not work on x86_64. i386 has a similar line, this could be the right fix. Would be nice to have in 2.6.13 final.

What do you mean by "this could be the right fix"? Did it work?

I cant test it due to lack of hardware. Will find someone who does. modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.

This works, tested it. modprobe -v aes
insmod /lib/modules/2.6.13-rc6-3-default/kernel/arch/x86_64/crypto/aes-x86_64.ko

#4 lore raw
Quoted 10 lines · Olaf Hering
Quoted 6 lines · Olaf Hering
Quoted 1 line · Andrew Morton

What do you mean by "this could be the right fix"? Did it work?

I cant test it due to lack of hardware. Will find someone who does. modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.

This works, tested it. modprobe -v aes
insmod /lib/modules/2.6.13-rc6-3-default/kernel/arch/x86_64/crypto/aes-x86_64.ko

It looks the same as the i386 version, so probably ok.

(CC'd the crypto maintainer).

- James

Signature · 2 lines
James Morris
<[email protected]>
maintainer
#5 lore raw

[AES] Add module alias to x86_64 implementation

Quoted 8 lines · James Morris
Quoted 6 lines
Quoted 3 lines

I cant test it due to lack of hardware. Will find someone who does. modprobe aes is done by openswan, works on ppc, i386, but not on x86_64.

This works, tested it. modprobe -v aes
insmod /lib/modules/2.6.13-rc6-3-default/kernel/arch/x86_64/crypto/aes-x86_64.ko

It looks the same as the i386 version, so probably ok.

It looks good to me too. Andrew, please add this to 2.6.13:

Subject: [AES] Add module alias to x86_64 implementation
From: Olaf Hering <[email protected]>

modprobe aes does not work on x86_64. i386 has a similar line,

Signed-off-by Olaf Hering <[email protected]>
Signed-off-by Herbert Xu <[email protected]>

Thanks,

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
arch/x86_64/crypto/aes.c +1 -0
@@ -322,3 +322,4 @@ module_exit(aes_fini);
 
 MODULE_DESCRIPTION("Rijndael (AES) Cipher Algorithm");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("aes");
maintainer
#6 lore raw

Re: [AES] Add module alias to x86_64 implementation

From: Herbert Xu <[email protected]>
Date: Thu, 11 Aug 2005 22:28:35 +1000

Quoted 1 line

It looks good to me too. Andrew, please add this to 2.6.13:

It's already in Linus's tree for a few days now.