Skip to contentSkip to conversation

removing odd number of parentheses

PATCH In review Carlo Perassi 3 participants 4 messages Aug 9, 2005 – Aug 10, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 removing odd number of parentheses

Hi.

Taking the idea from Alexey Dobriyan, I made those short trivial janitor patches.

I'd also suggest to add to the current TODO list something like "Even though it is not mandatory to Lindent each .[ch] file, make sure it does not output anything to stderr when processed with it." IMHO there are interesting things to do on this topic.

---

arch/ppc/syslib/qspan_pci.c +2 -2
@@ -366,13 +366,13 @@ int qspan_pcibios_find_class(unsigned in
 }
 
 void __init
-m8xx_pcibios_fixup(void))
+m8xx_pcibios_fixup(void)
 {
    /* Lots to do here, all board and configuration specific. */
 }
 
 void __init
-m8xx_setup_pci_ptrs(void))
+m8xx_setup_pci_ptrs(void)
 {
 	set_config_access_method(qspan);
 
drivers/video/sis/sis_main.c +1 -1
@@ -4411,7 +4411,7 @@ static void __devinit sisfb_post_sis3153
 
 	/* Get memory type */
 	if(ivideo->sishw_ext.UseROM) {
-	   if(ivideo->sishw_ext.pjVirtualRomBase[0x52] & 0x80)) {
+	   if(ivideo->sishw_ext.pjVirtualRomBase[0x52] & 0x80) {
 	      memtype = ivideo->sishw_ext.pjVirtualRomBase[0x52];
  	   } else {
 	      inSISIDXREG(SISSR,0x3a,memtype);

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Quoting Carlo Perassi <[email protected]>
Sent on Tue, 9 Aug 2005 16:09:40 +0200

Hello Carlo,

Quoted 1 line

if(ivideo->sishw_ext.UseROM) {

          ^

this should be "if ("

drivers/video/sis/sis_main.c static void __devinit sisfb_post_sis3153 · line 4414

Quoted 2 lines
drivers/video/sis/sis_main.c +1 -1
-	   if(ivideo->sishw_ext.pjVirtualRomBase[0x52] & 0x80)) {
+	   if(ivideo->sishw_ext.pjVirtualRomBase[0x52] & 0x80) {
             ^

this one too.

Signature · 5 lines
Ricardo Nabinger Sanchez
GNU/Linux #140696 [http://counter.li.org]
Slackware Linux + FreeBSD

  Left to themselves, things tend to go from bad to worse.

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Carlo Perassi
Quoted 1 line

this should be "if ("

I know (one of my latest patches was like that) but I read somewhere it is suggested to change one thing without reindenting around it. Anyway I will send a new version ASAP.

Signature · 6 lines
Carlo Perassi - http://www.linux.it/~carlo/

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
#3 lore raw
In reply to Carlo Perassi

arch/ppc/syslib/qspan_pci.c int qspan_pcibios_find_class(unsigned in · line 369

Quoted 6 lines · Carlo Perassi
arch/ppc/syslib/qspan_pci.c +1 -1
 
 void __init
-m8xx_pcibios_fixup(void))
+m8xx_pcibios_fixup(void)

I wasn't patient fighting with Gmail SMTP server. This line exists since 2.4.0 ;-).

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors