net/irda/: possible cleanups
Subsystems (2)
PATCH 1/1 net/irda/: possible cleanups
This patch contains the following possible cleanups:
- make the following needlessly global function static:
- irnet/irnet_ppp.c: irnet_init
- remove the following unneeded EXPORT_SYMBOL's:
- irlmp.c: sysctl_discovery_timeout
- irlmp.c: irlmp_reasons
- irlmp.c: irlmp_dup
- irqueue.c: hashbin_find_next
Please review which of these changes do make sense and which conflict with pending patches.
---
This patch was already sent on:
- 9 Jul 2005
- 30 May 2005
- 7 May 2005
net/irda/irlmp.c | 3 --- net/irda/irnet/irnet.h | 3 --- net/irda/irnet/irnet_ppp.c | 2 +- net/irda/irqueue.c | 1 - 4 files changed, 1 insertion(+), 8 deletions(-)
net/irda/irnet/irnet.h renamed from net/irda/irnet/irnet.h.old +0 -3
@@ -517,9 +517,6 @@irda_irnet_init (void);/* Initialise IrDA part of IrNET */ extern void irda_irnet_cleanup (void );/* Teardown IrDA part of IrNET */ -/* ---------------------------- MODULE ---------------------------- */ -extern int -irnet_init (void );/* Initialise IrNET module */ /**************************** VARIABLES ****************************/
net/irda/irnet/irnet_ppp.c renamed from net/irda/irnet/irnet_ppp.c.old +1 -1
@@ -1107,7 +1107,7 @@/* * Module main entry point */ -int __init +static int __init irnet_init (void ) {int err;
net/irda/irlmp.c renamed from net/irda/irlmp.c.old +0 -3
@@ -53,7 +53,6 @@/* These can be altered by the sysctl interface */ int sysctl_discovery =0 ;int sysctl_discovery_timeout =3 ;/* 3 seconds by default */ -EXPORT_SYMBOL (sysctl_discovery_timeout);int sysctl_discovery_slots =6 ;/* 6 slots by default */ int sysctl_lap_keepalive_time =LM_IDLE_TIMEOUT *1000 /HZ ;char sysctl_devname[65 ];
@@ -67,7 +66,6 @@"LM_INIT_DISCONNECT" , "ERROR, NOT USED", }; -EXPORT_SYMBOL (irlmp_reasons);/* * Function irlmp_init (void)
@@ -675,7 +673,6 @@return new; } -EXPORT_SYMBOL (irlmp_dup);/* * Function irlmp_disconnect_request (handle, userdata)
net/irda/irqueue.c renamed from net/irda/irqueue.c.old +0 -1
@@ -822,7 +822,6 @@return entry; } -EXPORT_SYMBOL (hashbin_find_next);/* * Function hashbin_get_first (hashbin)
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf