Skip to contentSkip to conversation

purpose of modular mca recovery

DISCUSSION Christoph Hellwig 3 participants 3 messages Aug 9, 2005

lore
Share & tools
lore
#0 lore raw

is there any reason to built this code modular? After all it would usually not be loaded when it was needed. Not allowing modular mca recovery would help greatly because it's using some symbols that we'd prefer to unexport before chaning some implementation details (tasklist_lock and maybe force_sig)

#1 lore raw
Quoted 6 lines · Christoph Hellwig

is there any reason to built this code modular? After all it would usually not be loaded when it was needed. Not allowing modular mca recovery would help greatly because it's using some symbols that we'd prefer to unexport before chaning some implementation details (tasklist_lock and maybe force_sig)

It is extremely handy for testing to be able to insmod/rmmod mca_recovery to test changes, rather than having to reboot the kernel. It is also a handly way to turn it on/off the recovery code or upgrade without having to reboot.

Signature · 2 lines
Russ Anderson, OS RAS/Partitioning Project Lead  
SGI - Silicon Graphics Inc          [email protected]
#2 lore raw
In reply to Christoph Hellwig
Quoted 5 lines

is there any reason to built this code modular? After all it would usually not be loaded when it was needed. Not allowing modular mca recovery would help greatly because it's using some symbols that we'd prefer to unexport before chaning some implementation details (tasklist_lock and maybe force_sig)

At the moment there are two reasons:
1) OS distributors don't trust this code very much and they seem to prefer to ship a kernel that doesn't have mca memory recovery enabled. But some do seem ok with the idea of supplying a module that a suitably knowlegable customer would load. This doesn't seem too unreasonable a position, after all memory error recovery does involve killing user applications.

2) Loading/unloading the module provides a mechanism to enable/disable memory error recovery ... so we aren't tempted to add some ugly file in /proc to do this.

Neither of these are really strong long-term arguments, but I'd prefer to keep things this way for a while longer until we can convice a few more people that this is good code to have built in as the default.

-Tony