Skip to contentSkip to conversation

resend: fix domain builder for >4GB PAE

PATCH In review Gerd Knorr 2 participants 2 messages Aug 10, 2005 x86

lore
Share & tools
lore

Gerd Knorr

author
#0 lore raw

PATCH 1/1 resend: fix domain builder for >4GB PAE

Hi,

Without that patch the domain builder BUG()s due to truncated physical addresses (found by Scott Parish).

Gerd

arch/x86/domain_build.c +4 -4
Index: xen/arch/x86/domain_build.c
===================================================================
@@ -78,8 +78,8 @@ int construct_dom0(struct domain *d,
     unsigned long pfn, mfn;
     unsigned long nr_pages;
     unsigned long nr_pt_pages;
-    unsigned long alloc_start;
-    unsigned long alloc_end;
+    physaddr_t alloc_start;
+    physaddr_t alloc_end;
     unsigned long count;
     struct pfn_info *page = NULL;
     start_info_t *si;
@@ -219,8 +219,8 @@ int construct_dom0(struct domain *d,
         panic("Insufficient contiguous RAM to build kernel image.\n");
 
     printk("PHYSICAL MEMORY ARRANGEMENT:\n"
-           " Dom0 alloc.:   %p->%p",
-           _p(alloc_start), _p(alloc_end));
+           " Dom0 alloc.:   %llx->%llx",
+           (u64)alloc_start, (u64)alloc_end);
     if ( d->tot_pages < nr_pages )
         printk(" (%lu pages to be allocated)",
                nr_pages - d->tot_pages);
#1 lore raw
Quoted 2 lines · Gerd Knorr

Without that patch the domain builder BUG()s due to truncated physical addresses (found by Scott Parish).

It's on my todo pile. I have some other cleanups I want to do at the same time.

- Keir