i386 / Make write ldt return error code
PATCH 1/14 i386 / Make write ldt return error code
Xen requires error returns from the hypercall to update LDT entries, and this generates completely equivalent code on native.
Patch-base: 2.6.13-rc5-mm1
Patch-keys: i386 desc ldt paravirt xen
include/asm-i386/mach-default/mach_desc.h +2 -1
@@ -62,11 +62,12 @@_set_tssldt_desc (&per_cpu (cpu_gdt_table, cpu)[GDT_ENTRY_LDT ], (int )addr, ((size <<3 )-1 ),0x82 ); } -static inline void write_ldt_entry (void *ldt,int entry,__u32 entry_a,__u32 entry_b) +static inline int write_ldt_entry (void *ldt,int entry,__u32 entry_a,__u32 entry_b) {__u32 *lp = (__u32 *)((char *)ldt + entry*8 ); *lp = entry_a; *(lp+1 ) = entry_b; +return 0 ; }#if TLS_SIZE !=24
arch/i386/kernel/ldt.c +1 -2
@@ -221,8 +221,7 @@/* Install the new entry ... */ install: -write_ldt_entry (mm->context.ldt, ldt_info.entry_number, entry_1, entry_2); - error =0 ; + error =write_ldt_entry (mm->context.ldt, ldt_info.entry_number, entry_1, entry_2); out_unlock:up (&mm->context.sem);
Quoted 2 lines · * [email protected] ([email protected]) wrote:
Xen requires error returns from the hypercall to update LDT entries, and this generates completely equivalent code on native.
The whole lot looks quite nice. I've sucked them into a git tree with the full set until Andrew's back. If it's useful we can work against that tree.
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/chrisw/virt-2.6
thanks,
-chris
Quoted 2 lines · On Wed, Aug 10, 2005 at 09:52:51PM -0700, [email protected] wrote:
Xen requires error returns from the hypercall to update LDT entries, and this generates completely equivalent code on native.
I don't think that is something we want. Nothing in the callers will check the errors anyways. If Xen has such a requirement it should kill the guest when it is violated, otherwise they will be ignored.
I would drop that one.
-Andi
Quoted 7 lines · * Andi Kleen ([email protected]) wrote:
Quoted 2 lines · On Wed, Aug 10, 2005 at 09:52:51PM -0700, [email protected] wrote:
Xen requires error returns from the hypercall to update LDT entries, and this generates completely equivalent code on native.
I don't think that is something we want. Nothing in the callers will check the errors anyways. If Xen has such a requirement it should kill the guest when it is violated, otherwise they will be ignored.
In this case the callers do propagate the error (unless you mean userspace doesn't check return value from syscall, which is same problem if copy_from_user failed, for example). Xen has done some more wrapping of the hypercalls to be effectively synchronous exceptions on error. Keir, Ian, is that preferred method going forward?
thanks,
-chris
Quoted 5 lines · Chris Wright
Quoted 4 lines · * Andi Kleen ([email protected]) wrote:
Quoted 2 lines · On Wed, Aug 10, 2005 at 09:52:51PM -0700, [email protected] wrote:
Xen requires error returns from the hypercall to update LDT entries, and this generates completely equivalent code on native.
Quoted 7 lines
Quoted 3 lines
I don't think that is something we want. Nothing in the callers will check the errors anyways. If Xen has such a requirement it should kill the guest when it is violated, otherwise they will be ignored.
In this case the callers do propagate the error (unless you mean userspace doesn't check return value from syscall, which is same problem if
copy_from_userfailed, for example). Xen has done some more wrapping
Nothing checks them in user space.
Also how would you handle them anyways? It just doesn't make sense.
-Andi
Quoted 8 lines · * Andi Kleen ([email protected]) wrote:
Quoted 3 lines · Chris Wright
In this case the callers do propagate the error (unless you mean userspace doesn't check return value from syscall, which is same problem if
copy_from_userfailed, for example). Xen has done some more wrappingNothing checks them in user space.
Also how would you handle them anyways? It just doesn't make sense.
Yes, I see your point, although copy_from_user failing has similar issue if userspace isn't checking errors. But this one is not critical.
thanks,
-chris